Add an experiment for stricter pacing and ALR probing.

Add an experiment for stricter pacing and ALR probing.

BUG=webrtc:8072
Review-Url: https://codereview.webrtc.org/2994623002
Cr-Commit-Position: refs/heads/master@{#19270}
Committed: https://chromium.googlesource.com/external/webrtc/+/d7a418f93a5f7a91af41fc831c607ff36df56d40

[stefan-webrtc, 2017-08-08 11:36:22]

stefan@webrtc.org changed reviewers:
+ philipel@webrtc.org

[philipel, 2017-08-08 11:48:55]

https://codereview.webrtc.org/2994623002/diff/1/webrtc/modules/pacing/alr_det...
File webrtc/modules/pacing/alr_detector.cc (right):

https://codereview.webrtc.org/2994623002/diff/1/webrtc/modules/pacing/alr_det...
webrtc/modules/pacing/alr_detector.cc:35: if (!experiment_settings) {
Do we ever expect these two experiments to be on at the same time? I guess not
but if that was the case it could affect the result of the video experiment.
Maybe add a CHECK?

https://codereview.webrtc.org/2994623002/diff/1/webrtc/modules/pacing/alr_det...
webrtc/modules/pacing/alr_detector.cc:107: LOG(LS_INFO) << "Failed to parse ALR
experiment: " << group_name;
Also print the |experiment_name| so we know which experiment parameters that
failed to be parsed.

https://codereview.webrtc.org/2994623002/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/2994623002/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:832: alr_settings =
AlrDetector::ParseAlrSettingsFromFieldTrial(
CHECK that not both experiments...?

[stefan-webrtc, 2017-08-08 12:20:52]

https://codereview.webrtc.org/2994623002/diff/1/webrtc/modules/pacing/alr_det...
File webrtc/modules/pacing/alr_detector.cc (right):

https://codereview.webrtc.org/2994623002/diff/1/webrtc/modules/pacing/alr_det...
webrtc/modules/pacing/alr_detector.cc:35: if (!experiment_settings) {
On 2017/08/08 11:48:54, philipel wrote:
> Do we ever expect these two experiments to be on at the same time? I guess not
> but if that was the case it could affect the result of the video experiment.
> Maybe add a CHECK?

Sure

https://codereview.webrtc.org/2994623002/diff/1/webrtc/modules/pacing/alr_det...
webrtc/modules/pacing/alr_detector.cc:107: LOG(LS_INFO) << "Failed to parse ALR
experiment: " << group_name;
On 2017/08/08 11:48:54, philipel wrote:
> Also print the |experiment_name| so we know which experiment parameters that
> failed to be parsed.

Done.

https://codereview.webrtc.org/2994623002/diff/1/webrtc/video/video_send_strea...
File webrtc/video/video_send_stream.cc (right):

https://codereview.webrtc.org/2994623002/diff/1/webrtc/video/video_send_strea...
webrtc/video/video_send_stream.cc:832: alr_settings =
AlrDetector::ParseAlrSettingsFromFieldTrial(
On 2017/08/08 11:48:55, philipel wrote:
> CHECK that not both experiments...?

Done.

[philipel, 2017-08-08 12:29:36]

lgtm

[stefan-webrtc, 2017-08-08 12:53:14]

The CQ bit was checked by stefan@webrtc.org

[commit-bot: I haz the power, 2017-08-08 12:53:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-08 13:51:05]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1502196794599170,
"parent_rev": "cf189c60d21538d468a552d950237721e3d3dc87", "commit_rev":
"d7a418f93a5f7a91af41fc831c607ff36df56d40"}

[commit-bot: I haz the power, 2017-08-08 13:51:13]

Description was changed from

==========
Add an experiment for stricter pacing and ALR probing.

BUG=webrtc:8072
==========

to

==========
Add an experiment for stricter pacing and ALR probing.

BUG=webrtc:8072

Review-Url: https://codereview.webrtc.org/2994623002
Cr-Commit-Position: refs/heads/master@{#19270}
Committed:
https://chromium.googlesource.com/external/webrtc/+/d7a418f93a5f7a91af41fc831...
==========

[commit-bot: I haz the power, 2017-08-08 13:51:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/d7a418f93a5f7a91af41fc831...