Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: webrtc/video/video_send_stream.cc

Issue 2994623002: Add an experiment for stricter pacing and ALR probing. (Closed)
Patch Set: Comments addressed. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/pacing/alr_detector.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/video/video_send_stream.cc
diff --git a/webrtc/video/video_send_stream.cc b/webrtc/video/video_send_stream.cc
index 2c3a5c495c4398927b7ef7c99a327a2251f5b3f9..40dfc433bd57965d3bec60c69018675bb8bd0412 100644
--- a/webrtc/video/video_send_stream.cc
+++ b/webrtc/video/video_send_stream.cc
@@ -824,17 +824,26 @@ VideoSendStreamImpl::VideoSendStreamImpl(
RTC_DCHECK(call_stats_);
RTC_DCHECK(transport_);
RTC_DCHECK(transport_->send_side_cc());
-
+ RTC_CHECK(field_trial::FindFullName(
+ AlrDetector::kStrictPacingAndProbingExperimentName)
+ .empty() ||
+ field_trial::FindFullName(
+ AlrDetector::kScreenshareProbingBweExperimentName)
+ .empty());
+ rtc::Optional<AlrDetector::AlrExperimentSettings> alr_settings;
if (content_type == VideoEncoderConfig::ContentType::kScreen) {
- rtc::Optional<AlrDetector::AlrExperimentSettings> alr_settings =
- AlrDetector::ParseAlrSettingsFromFieldTrial();
- if (alr_settings) {
- transport->send_side_cc()->EnablePeriodicAlrProbing(true);
- transport->send_side_cc()->pacer()->SetPacingFactor(
- alr_settings->pacing_factor);
- transport->send_side_cc()->pacer()->SetQueueTimeLimit(
- alr_settings->max_paced_queue_time);
- }
+ alr_settings = AlrDetector::ParseAlrSettingsFromFieldTrial(
+ AlrDetector::kScreenshareProbingBweExperimentName);
+ } else {
+ alr_settings = AlrDetector::ParseAlrSettingsFromFieldTrial(
+ AlrDetector::kStrictPacingAndProbingExperimentName);
+ }
+ if (alr_settings) {
+ transport->send_side_cc()->EnablePeriodicAlrProbing(true);
+ transport->send_side_cc()->pacer()->SetPacingFactor(
+ alr_settings->pacing_factor);
+ transport->send_side_cc()->pacer()->SetQueueTimeLimit(
+ alr_settings->max_paced_queue_time);
}
if (config_->periodic_alr_bandwidth_probing) {
« no previous file with comments | « webrtc/modules/pacing/alr_detector.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698