Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1228)

Side by Side Diff: webrtc/modules/pacing/alr_detector.h

Issue 2994623002: Add an experiment for stricter pacing and ALR probing. (Closed)
Patch Set: Comments addressed. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/modules/pacing/alr_detector.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 30 matching lines...) Expand all
41 // started or empty result if the sender is currently not application-limited. 41 // started or empty result if the sender is currently not application-limited.
42 rtc::Optional<int64_t> GetApplicationLimitedRegionStartTime() const; 42 rtc::Optional<int64_t> GetApplicationLimitedRegionStartTime() const;
43 43
44 struct AlrExperimentSettings { 44 struct AlrExperimentSettings {
45 float pacing_factor = PacedSender::kDefaultPaceMultiplier; 45 float pacing_factor = PacedSender::kDefaultPaceMultiplier;
46 int64_t max_paced_queue_time = PacedSender::kMaxQueueLengthMs; 46 int64_t max_paced_queue_time = PacedSender::kMaxQueueLengthMs;
47 int alr_bandwidth_usage_percent = kDefaultAlrBandwidthUsagePercent; 47 int alr_bandwidth_usage_percent = kDefaultAlrBandwidthUsagePercent;
48 int alr_start_budget_level_percent = kDefaultAlrStartBudgetLevelPercent; 48 int alr_start_budget_level_percent = kDefaultAlrStartBudgetLevelPercent;
49 int alr_stop_budget_level_percent = kDefaultAlrStopBudgetLevelPercent; 49 int alr_stop_budget_level_percent = kDefaultAlrStopBudgetLevelPercent;
50 }; 50 };
51 static rtc::Optional<AlrExperimentSettings> ParseAlrSettingsFromFieldTrial(); 51 static rtc::Optional<AlrExperimentSettings> ParseAlrSettingsFromFieldTrial(
52 const char* experiment_name);
52 53
53 // Sent traffic percentage as a function of network capacity used to determine 54 // Sent traffic percentage as a function of network capacity used to determine
54 // application-limited region. ALR region start when bandwidth usage drops 55 // application-limited region. ALR region start when bandwidth usage drops
55 // below kAlrStartUsagePercent and ends when it raises above 56 // below kAlrStartUsagePercent and ends when it raises above
56 // kAlrEndUsagePercent. NOTE: This is intentionally conservative at the moment 57 // kAlrEndUsagePercent. NOTE: This is intentionally conservative at the moment
57 // until BW adjustments of application limited region is fine tuned. 58 // until BW adjustments of application limited region is fine tuned.
58 static constexpr int kDefaultAlrBandwidthUsagePercent = 65; 59 static constexpr int kDefaultAlrBandwidthUsagePercent = 65;
59 static constexpr int kDefaultAlrStartBudgetLevelPercent = 80; 60 static constexpr int kDefaultAlrStartBudgetLevelPercent = 80;
60 static constexpr int kDefaultAlrStopBudgetLevelPercent = 50; 61 static constexpr int kDefaultAlrStopBudgetLevelPercent = 50;
61 static const char* kScreenshareProbingBweExperimentName; 62 static const char* kScreenshareProbingBweExperimentName;
63 static const char* kStrictPacingAndProbingExperimentName;
62 64
63 void UpdateBudgetWithElapsedTime(int64_t delta_time_ms); 65 void UpdateBudgetWithElapsedTime(int64_t delta_time_ms);
64 void UpdateBudgetWithBytesSent(size_t bytes_sent); 66 void UpdateBudgetWithBytesSent(size_t bytes_sent);
65 67
66 private: 68 private:
67 int bandwidth_usage_percent_; 69 int bandwidth_usage_percent_;
68 int alr_start_budget_level_percent_; 70 int alr_start_budget_level_percent_;
69 int alr_stop_budget_level_percent_; 71 int alr_stop_budget_level_percent_;
70 72
71 IntervalBudget alr_budget_; 73 IntervalBudget alr_budget_;
72 rtc::Optional<int64_t> alr_started_time_ms_; 74 rtc::Optional<int64_t> alr_started_time_ms_;
73 }; 75 };
74 76
75 } // namespace webrtc 77 } // namespace webrtc
76 78
77 #endif // WEBRTC_MODULES_PACING_ALR_DETECTOR_H_ 79 #endif // WEBRTC_MODULES_PACING_ALR_DETECTOR_H_
OLDNEW
« no previous file with comments | « no previous file | webrtc/modules/pacing/alr_detector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698