Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2994343002: Reland of Add functionality which limits the number of bytes on the network. (Closed)

Created:
3 years, 4 months ago by stefan-webrtc
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Add functionality which limits the number of bytes on the network. (patchset #1 id:1 of https://codereview.webrtc.org/3001653002/ ) Reason for revert: Reland Original issue's description: > Revert of Add functionality which limits the number of bytes on the network. (patchset #26 id:500001 of https://codereview.webrtc.org/2918323002/ ) > > Reason for revert: > Speculative revert to see if this caused regressions in android perf tests. > > Original issue's description: > > Add functionality which limits the number of bytes on the network. > > > > The limit is based on the bandwidth delay product, but also adds some additional slack to compensate for the sawtooth-like BWE pattern and the slowness of the encoder rate control. The delay is estimated based on the time from sending a packet until an ack is received. Since acks are received in bursts (feedback is only sent periodically), a min filter is used to estimate the rtt. > > > > Whenever the in flight bytes reaches the congestion window, the pacer is paused, which in turn will result in send-side queues growing. Eventually the encoders will be paused as the pacer queue grows large (currently 2 seconds). > > > > BUG=webrtc:7926 > > > > Review-Url: https://codereview.webrtc.org/2918323002 > > Cr-Commit-Position: refs/heads/master@{#19289} > > Committed: https://chromium.googlesource.com/external/webrtc/+/8497fdde43d920ab1f0cc90362534e5493d23abe > > TBR=terelius@webrtc.org,philipel@webrtc.org,tschumim@webrtc.org,gnish@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7926 > > Review-Url: https://codereview.webrtc.org/3001653002 > Cr-Commit-Position: refs/heads/master@{#19339} > Committed: https://chromium.googlesource.com/external/webrtc/+/64136af364d1fecada49e35b1bfa39ef2641d5d0 TBR=terelius@webrtc.org,philipel@webrtc.org,tschumim@webrtc.org,gnish@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7926 Review-Url: https://codereview.webrtc.org/2994343002 Cr-Commit-Position: refs/heads/master@{#19373} Committed: https://chromium.googlesource.com/external/webrtc/+/9e117c5e1b279aa2920786351eaf72b4f07ce295

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -38 lines) Patch
M webrtc/call/call.cc View 2 chunks +15 lines, -8 lines 0 comments Download
M webrtc/modules/congestion_controller/include/send_side_congestion_controller.h View 2 chunks +7 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/send_side_congestion_controller.cc View 6 chunks +58 lines, -5 lines 0 comments Download
M webrtc/modules/congestion_controller/transport_feedback_adapter.h View 3 chunks +6 lines, -0 lines 0 comments Download
M webrtc/modules/congestion_controller/transport_feedback_adapter.cc View 6 chunks +29 lines, -2 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 9 chunks +29 lines, -11 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 2 chunks +14 lines, -6 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/send_time_history.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/send_time_history.cc View 2 chunks +20 lines, -0 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 6 chunks +87 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
stefan-webrtc
Created Reland of Add functionality which limits the number of bytes on the network.
3 years, 4 months ago (2017-08-16 13:59:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2994343002/1
3 years, 4 months ago (2017-08-16 14:00:02 UTC) #3
commit-bot: I haz the power
3 years, 4 months ago (2017-08-16 15:16:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/9e117c5e1b279aa2920786351...

Powered by Google App Engine
This is Rietveld 408576698