Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 3001653002: Revert of Add functionality which limits the number of bytes on the network. (Closed)

Created:
3 years, 4 months ago by stefan-webrtc
Modified:
3 years, 4 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, tterriberry_mozilla.com, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Add functionality which limits the number of bytes on the network. (patchset #26 id:500001 of https://codereview.webrtc.org/2918323002/ ) Reason for revert: Speculative revert to see if this caused regressions in android perf tests. Original issue's description: > Add functionality which limits the number of bytes on the network. > > The limit is based on the bandwidth delay product, but also adds some additional slack to compensate for the sawtooth-like BWE pattern and the slowness of the encoder rate control. The delay is estimated based on the time from sending a packet until an ack is received. Since acks are received in bursts (feedback is only sent periodically), a min filter is used to estimate the rtt. > > Whenever the in flight bytes reaches the congestion window, the pacer is paused, which in turn will result in send-side queues growing. Eventually the encoders will be paused as the pacer queue grows large (currently 2 seconds). > > BUG=webrtc:7926 > > Review-Url: https://codereview.webrtc.org/2918323002 > Cr-Commit-Position: refs/heads/master@{#19289} > Committed: https://chromium.googlesource.com/external/webrtc/+/8497fdde43d920ab1f0cc90362534e5493d23abe TBR=terelius@webrtc.org,philipel@webrtc.org,tschumim@webrtc.org,gnish@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7926 Review-Url: https://codereview.webrtc.org/3001653002 Cr-Commit-Position: refs/heads/master@{#19339} Committed: https://chromium.googlesource.com/external/webrtc/+/64136af364d1fecada49e35b1bfa39ef2641d5d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -268 lines) Patch
M webrtc/call/call.cc View 2 chunks +7 lines, -14 lines 0 comments Download
M webrtc/modules/congestion_controller/include/send_side_congestion_controller.h View 2 chunks +0 lines, -7 lines 0 comments Download
M webrtc/modules/congestion_controller/send_side_congestion_controller.cc View 6 chunks +5 lines, -58 lines 0 comments Download
M webrtc/modules/congestion_controller/transport_feedback_adapter.h View 3 chunks +0 lines, -6 lines 0 comments Download
M webrtc/modules/congestion_controller/transport_feedback_adapter.cc View 6 chunks +2 lines, -29 lines 0 comments Download
M webrtc/modules/pacing/paced_sender.cc View 9 chunks +11 lines, -29 lines 0 comments Download
M webrtc/modules/pacing/paced_sender_unittest.cc View 2 chunks +6 lines, -14 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/include/send_time_history.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/modules/remote_bitrate_estimator/send_time_history.cc View 2 chunks +0 lines, -20 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 6 chunks +6 lines, -87 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
stefan-webrtc
Created Revert of Add functionality which limits the number of bytes on the network.
3 years, 4 months ago (2017-08-14 08:49:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3001653002/1
3 years, 4 months ago (2017-08-14 08:49:28 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_gcc_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_gcc_rel/builds/1232) linux_rel on master.tryserver.webrtc (JOB_FAILED, ...
3 years, 4 months ago (2017-08-14 08:51:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/3001653002/1
3 years, 4 months ago (2017-08-14 12:56:16 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/64136af364d1fecada49e35b1bfa39ef2641d5d0
3 years, 4 months ago (2017-08-14 15:03:24 UTC) #10
stefan-webrtc
3 years, 4 months ago (2017-08-16 13:59:52 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2994343002/ by stefan@webrtc.org.

The reason for reverting is: Reland.

Powered by Google App Engine
This is Rietveld 408576698