Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2993253002: Make line-starts 32-bits TypedData instead of Array of smis.

Created:
3 years, 4 months ago by jensj
Modified:
3 years, 2 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make line-starts 32-bits TypedData instead of Array of smis. While investigating snapshots in kernel it seemed that we stored ~9 bits per smi we saved for line-starts. While that is technically true, there also seems to be deduplication at play, meaning that we in a hello-world example store ~45,000 smis at ~9 bits each, vs when we store TypedData (without deduplication) we store ~80,000 ints at ~4 bits per entry. So while this does save ~92 KB it is not at much as was hoped. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -53 lines) Patch
M runtime/vm/kernel_binary_flowgraph.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/kernel_binary_flowgraph.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M runtime/vm/object.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 7 chunks +41 lines, -41 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (1 generated)
jensj
I don't know whether this is worth it, given that we save less that what ...
3 years, 4 months ago (2017-08-08 09:06:13 UTC) #2
David2000
Cartoon HD@ https://getcartoonhd.com/ ShowBox@ https://showbox.ooo/ Aptoide@ https://aptoideguide.com/
3 years, 4 months ago (2017-08-09 13:27:36 UTC) #3
amaze244
Kingroot - https://androidrootapk.com/kingroot-apk/ Mobdro - https://mobdrodl.com Showbox - https://showboxdownload.site
3 years, 3 months ago (2017-09-17 13:21:48 UTC) #4
amber.gandotra
https://tweakboxappdownload.com/ https://192168l254.online/
3 years, 2 months ago (2017-09-22 07:10:46 UTC) #5
ashishkochaar
3 years, 2 months ago (2017-09-23 11:26:39 UTC) #6
This is really very interesting.

If you do the online transactions then I suggest you to have a look at
http://allbankroutingnumnber.com
This will help you to buy these APK files in very easy steps.

Powered by Google App Engine
This is Rietveld 408576698