Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2993613002: [kernel] Make snapshotting work. (Closed)

Created:
3 years, 4 months ago by jensj
Modified:
3 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[kernel] Make snapshotting work. This CL enables snapshotting for kernel. Basically what it does is that it writes out and reads in a few previously missing entries in the snapshot file (from Field, Function and Script). Debugging from a snapshot made from kernel will not work as snapshots does not contain sourcecode (it is normally synthesized from the TokenStream which doesn't exist in kernel). BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/60ed069e7cdbebc266773fd4643cd9227f3f28ee

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -8 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/clustered_snapshot.cc View 6 chunks +10 lines, -0 lines 0 comments Download
M runtime/vm/raw_object.h View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 6 chunks +15 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
jensj
Notice that this builds on top of other currently un-landed CLs. Only tested on helloworld.dart ...
3 years, 4 months ago (2017-08-03 13:03:48 UTC) #1
jensj
3 years, 4 months ago (2017-08-03 13:04:59 UTC) #3
Kevin Millikin (Google)
LGTM.
3 years, 4 months ago (2017-08-09 09:37:40 UTC) #4
jensj
3 years, 4 months ago (2017-08-10 08:26:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
60ed069e7cdbebc266773fd4643cd9227f3f28ee (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698