Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: runtime/vm/object.h

Issue 2993253002: Make line-starts 32-bits TypedData instead of Array of smis.
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/kernel_binary_flowgraph.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef RUNTIME_VM_OBJECT_H_ 5 #ifndef RUNTIME_VM_OBJECT_H_
6 #define RUNTIME_VM_OBJECT_H_ 6 #define RUNTIME_VM_OBJECT_H_
7 7
8 #include "include/dart_api.h" 8 #include "include/dart_api.h"
9 #include "platform/assert.h" 9 #include "platform/assert.h"
10 #include "platform/utils.h" 10 #include "platform/utils.h"
(...skipping 3665 matching lines...) Expand 10 before | Expand all | Expand 10 after
3676 RawTypedData* kernel_canonical_names() const { 3676 RawTypedData* kernel_canonical_names() const {
3677 return raw_ptr()->kernel_canonical_names_; 3677 return raw_ptr()->kernel_canonical_names_;
3678 } 3678 }
3679 void set_kernel_canonical_names(const TypedData& names) const; 3679 void set_kernel_canonical_names(const TypedData& names) const;
3680 3680
3681 RawTokenStream* tokens() const { 3681 RawTokenStream* tokens() const {
3682 ASSERT(kind() != RawScript::kKernelTag); 3682 ASSERT(kind() != RawScript::kKernelTag);
3683 return raw_ptr()->tokens_; 3683 return raw_ptr()->tokens_;
3684 } 3684 }
3685 3685
3686 void set_line_starts(const Array& value) const; 3686 void set_line_starts(const TypedData& value) const;
3687 3687
3688 void set_debug_positions(const Array& value) const; 3688 void set_debug_positions(const Array& value) const;
3689 3689
3690 void set_yield_positions(const Array& value) const; 3690 void set_yield_positions(const Array& value) const;
3691 3691
3692 RawArray* yield_positions() const; 3692 RawArray* yield_positions() const;
3693 3693
3694 void Tokenize(const String& private_key, bool use_shared_tokens = true) const; 3694 void Tokenize(const String& private_key, bool use_shared_tokens = true) const;
3695 3695
3696 RawLibrary* FindLibrary() const; 3696 RawLibrary* FindLibrary() const;
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
3734 const String& source, 3734 const String& source,
3735 RawScript::Kind kind); 3735 RawScript::Kind kind);
3736 3736
3737 private: 3737 private:
3738 void set_url(const String& value) const; 3738 void set_url(const String& value) const;
3739 void set_resolved_url(const String& value) const; 3739 void set_resolved_url(const String& value) const;
3740 void set_source(const String& value) const; 3740 void set_source(const String& value) const;
3741 void set_kind(RawScript::Kind value) const; 3741 void set_kind(RawScript::Kind value) const;
3742 void set_load_timestamp(int64_t value) const; 3742 void set_load_timestamp(int64_t value) const;
3743 void set_tokens(const TokenStream& value) const; 3743 void set_tokens(const TokenStream& value) const;
3744 RawArray* line_starts() const; 3744 RawTypedData* line_starts() const;
3745 RawArray* debug_positions() const; 3745 RawArray* debug_positions() const;
3746 3746
3747 static RawScript* New(); 3747 static RawScript* New();
3748 3748
3749 FINAL_HEAP_OBJECT_IMPLEMENTATION(Script, Object); 3749 FINAL_HEAP_OBJECT_IMPLEMENTATION(Script, Object);
3750 friend class Class; 3750 friend class Class;
3751 friend class Precompiler; 3751 friend class Precompiler;
3752 }; 3752 };
3753 3753
3754 class DictionaryIterator : public ValueObject { 3754 class DictionaryIterator : public ValueObject {
(...skipping 5249 matching lines...) Expand 10 before | Expand all | Expand 10 after
9004 9004
9005 inline void TypeArguments::SetHash(intptr_t value) const { 9005 inline void TypeArguments::SetHash(intptr_t value) const {
9006 // This is only safe because we create a new Smi, which does not cause 9006 // This is only safe because we create a new Smi, which does not cause
9007 // heap allocation. 9007 // heap allocation.
9008 StoreSmi(&raw_ptr()->hash_, Smi::New(value)); 9008 StoreSmi(&raw_ptr()->hash_, Smi::New(value));
9009 } 9009 }
9010 9010
9011 } // namespace dart 9011 } // namespace dart
9012 9012
9013 #endif // RUNTIME_VM_OBJECT_H_ 9013 #endif // RUNTIME_VM_OBJECT_H_
OLDNEW
« no previous file with comments | « runtime/vm/kernel_binary_flowgraph.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698