Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2993063002: Remove source file writer from VideoProcessor. (Closed)

Created:
3 years, 4 months ago by brandtr
Modified:
3 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove source file writer from VideoProcessor. It serves a very limited purpose: converting from the input YUV file to an output Y4M file. The experimenter can do this manually, if this is of interest. (It is generally not.) BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2993063002 Cr-Commit-Position: refs/heads/master@{#19257} Committed: https://chromium.googlesource.com/external/webrtc/+/c287c80781cca3dcdbb7399903908a9d1c11968c

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : video_quality_measurement updates. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -38 lines) Patch
M webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 2 chunks +4 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 1 3 chunks +0 lines, -12 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 2 5 chunks +1 line, -13 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/tools/video_quality_measurement.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (9 generated)
brandtr
3 years, 4 months ago (2017-08-07 09:24:02 UTC) #2
brandtr
Rebase.
3 years, 4 months ago (2017-08-07 09:30:41 UTC) #3
åsapersson
lgtm
3 years, 4 months ago (2017-08-07 13:34:33 UTC) #4
brandtr
Rebase.
3 years, 4 months ago (2017-08-07 14:42:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2993063002/60001
3 years, 4 months ago (2017-08-07 15:28:02 UTC) #12
commit-bot: I haz the power
3 years, 4 months ago (2017-08-07 15:30:50 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/c287c80781cca3dcdbb739990...

Powered by Google App Engine
This is Rietveld 408576698