Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2994613002: Remove VideoProcessor interface. (Closed)

Created:
3 years, 4 months ago by brandtr
Modified:
3 years, 4 months ago
Reviewers:
åsapersson
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VideoProcessor interface. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2994613002 Cr-Commit-Position: refs/heads/master@{#19256} Committed: https://chromium.googlesource.com/external/webrtc/+/c409552052a298070a24f9385c65ebb31c92b4c7

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase. #

Patch Set 4 : asapersson comments 1. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -78 lines) Patch
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 4 chunks +28 lines, -44 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 1 7 chunks +24 lines, -24 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/tools/video_quality_measurement.cc View 1 2 3 1 chunk +4 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
brandtr
Two small followups :)
3 years, 4 months ago (2017-08-07 09:23:38 UTC) #2
brandtr
Rebase.
3 years, 4 months ago (2017-08-07 09:30:26 UTC) #3
åsapersson
lgtm Should tools/video_quality_measurement.cc also be updated?
3 years, 4 months ago (2017-08-07 12:18:34 UTC) #4
brandtr
Rebase.
3 years, 4 months ago (2017-08-07 14:37:38 UTC) #5
brandtr
On 2017/08/07 12:18:34, åsapersson wrote: > lgtm > > Should tools/video_quality_measurement.cc also be updated? Yes. ...
3 years, 4 months ago (2017-08-07 14:41:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2994613002/60001
3 years, 4 months ago (2017-08-07 14:42:22 UTC) #9
commit-bot: I haz the power
3 years, 4 months ago (2017-08-07 15:12:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/c409552052a298070a24f9385...

Powered by Google App Engine
This is Rietveld 408576698