Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: webrtc/modules/video_coding/codecs/test/videoprocessor.h

Issue 2993063002: Remove source file writer from VideoProcessor. (Closed)
Patch Set: video_quality_measurement updates. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/codecs/test/videoprocessor.h
diff --git a/webrtc/modules/video_coding/codecs/test/videoprocessor.h b/webrtc/modules/video_coding/codecs/test/videoprocessor.h
index f939009c8d6e1154c981e7b6ce8fc16ee0b5c1a4..56c70541e7c0d9a4ee174c371f96ec93856f9d3b 100644
--- a/webrtc/modules/video_coding/codecs/test/videoprocessor.h
+++ b/webrtc/modules/video_coding/codecs/test/videoprocessor.h
@@ -145,7 +145,6 @@ class VideoProcessor {
PacketManipulator* packet_manipulator,
const TestConfig& config,
Stats* stats,
- FrameWriter* source_frame_writer,
IvfFileWriter* encoded_frame_writer,
FrameWriter* decoded_frame_writer);
~VideoProcessor();
@@ -287,13 +286,10 @@ class VideoProcessor {
FrameReader* const analysis_frame_reader_;
FrameWriter* const analysis_frame_writer_;
- // These (optional) file writers are used for persistently storing the output
- // of the coding pipeline at different stages: pre encode (source), post
- // encode (encoded), and post decode (decoded). The purpose is to give the
- // experimenter an option to subjectively evaluate the quality of the
- // encoding, given the test settings. Each frame writer is enabled by being
- // non-null.
- FrameWriter* const source_frame_writer_;
+ // These (optional) file writers are used to persistently store the encoded
+ // and decoded bitstreams. The purpose is to give the experimenter an option
+ // to subjectively evaluate the quality of the processing. Each frame writer
+ // is enabled by being non-null.
IvfFileWriter* const encoded_frame_writer_;
FrameWriter* const decoded_frame_writer_;

Powered by Google App Engine
This is Rietveld 408576698