Remove DCHECK from Call's ctor that could never fail

Remove DCHECK from Call's ctor that could never fail

I don't think this line could never conceivably fail - if the ctor has reached that point, the object fit in memory, and its members have all been allocated legal memory addresses, none of which may be 0x00.

BUG=None

Review-Url: https://codereview.webrtc.org/2989813002
Cr-Commit-Position: refs/heads/master@{#19176}
Committed: https://chromium.googlesource.com/external/webrtc/+/eaec1182402d6aeac42fb2b36a758005f094e769

[eladalon, 2017-07-27 14:14:38]

eladalon@webrtc.org changed reviewers:
+ danilchap@webrtc.org, solenberg@webrtc.org

[eladalon, 2017-07-27 14:14:38]

PTAL

[eladalon, 2017-07-27 14:25:58]

By the way, it might be that the intention was to use RTC_DCHECK_RUN_ON, but
that too cannot fail if called from the ctor, as the ctor is setting the
expected thread to be the thread on which it's running.

[danilchap, 2017-07-27 14:31:54]

lgtm

https://codereview.webrtc.org/2989813002/diff/1/webrtc/call/call.cc
File webrtc/call/call.cc (left):

https://codereview.webrtc.org/2989813002/diff/1/webrtc/call/call.cc#oldcode420
webrtc/call/call.cc:420: RTC_DCHECK(&configuration_thread_checker_);
my guess RTC_DCHECK_RUN_ON was intended instead - but that is implicit too.

[eladalon, 2017-07-27 15:30:31]

Great minds think alike. :-)
Fredrick, could you owner-approve?

[the sun, 2017-07-28 07:06:05]

lgtm

[eladalon, 2017-07-28 08:49:16]

The CQ bit was checked by eladalon@webrtc.org

[commit-bot: I haz the power, 2017-07-28 08:49:20]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-28 09:25:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1501231756500710, "parent_rev":
"4cd599f02504e32224a688434db6d43f5c892167", "commit_rev":
"eaec1182402d6aeac42fb2b36a758005f094e769"}

[commit-bot: I haz the power, 2017-07-28 09:25:15]

Description was changed from

==========
Remove DCHECK from Call's ctor that could never fail

I don't think this line could never conceivably fail - if the ctor has reached
that point, the object fit in memory, and its members have all been allocated
legal memory addresses, none of which may be 0x00.

BUG=None
==========

to

==========
Remove DCHECK from Call's ctor that could never fail

I don't think this line could never conceivably fail - if the ctor has reached
that point, the object fit in memory, and its members have all been allocated
legal memory addresses, none of which may be 0x00.

BUG=None

Review-Url: https://codereview.webrtc.org/2989813002
Cr-Commit-Position: refs/heads/master@{#19176}
Committed:
https://chromium.googlesource.com/external/webrtc/+/eaec1182402d6aeac42fb2b36...
==========

[commit-bot: I haz the power, 2017-07-28 09:25:16]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/eaec1182402d6aeac42fb2b36...