webrtc/call/call.cc - Issue 2989813002: Remove DCHECK from Call's ctor that could never fail

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/call/call.cc

Issue 2989813002: Remove DCHECK from Call's ctor that could never fail (Closed)

Patch Set: Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/call/call.cc

diff --git a/webrtc/call/call.cc b/webrtc/call/call.cc

index 26d97aad52100b7443f860e35875f2921b67026a..25dcf32a620c48965c22077d8c6d35cc3b298267 100644

--- a/webrtc/call/call.cc

+++ b/webrtc/call/call.cc

@@ -417,7 +417,6 @@ Call::Call(const Call::Config& config,

start_ms_(clock_->TimeInMilliseconds()),

worker_queue_("call_worker_queue"),

base_bitrate_config_(config.bitrate_config) {

- RTC_DCHECK(&configuration_thread_checker_);

danilchap 2017/07/27 14:31:54 my guess RTC_DCHECK_RUN_ON was intended instead -

RTC_DCHECK(config.event_log != nullptr);

RTC_DCHECK_GE(config.bitrate_config.min_bitrate_bps, 0);

RTC_DCHECK_GE(config.bitrate_config.start_bitrate_bps,

« no previous file with comments | « no previous file | no next file » | no next file with comments »