Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: webrtc/call/call.cc

Issue 2989813002: Remove DCHECK from Call's ctor that could never fail (Closed)
Patch Set: Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 399 matching lines...) Expand 10 before | Expand all | Expand 10 after
410 received_rtcp_bytes_per_second_counter_(clock_, nullptr, true), 410 received_rtcp_bytes_per_second_counter_(clock_, nullptr, true),
411 min_allocated_send_bitrate_bps_(0), 411 min_allocated_send_bitrate_bps_(0),
412 configured_max_padding_bitrate_bps_(0), 412 configured_max_padding_bitrate_bps_(0),
413 estimated_send_bitrate_kbps_counter_(clock_, nullptr, true), 413 estimated_send_bitrate_kbps_counter_(clock_, nullptr, true),
414 pacer_bitrate_kbps_counter_(clock_, nullptr, true), 414 pacer_bitrate_kbps_counter_(clock_, nullptr, true),
415 receive_side_cc_(clock_, transport_send->packet_router()), 415 receive_side_cc_(clock_, transport_send->packet_router()),
416 video_send_delay_stats_(new SendDelayStats(clock_)), 416 video_send_delay_stats_(new SendDelayStats(clock_)),
417 start_ms_(clock_->TimeInMilliseconds()), 417 start_ms_(clock_->TimeInMilliseconds()),
418 worker_queue_("call_worker_queue"), 418 worker_queue_("call_worker_queue"),
419 base_bitrate_config_(config.bitrate_config) { 419 base_bitrate_config_(config.bitrate_config) {
420 RTC_DCHECK(&configuration_thread_checker_);
danilchap 2017/07/27 14:31:54 my guess RTC_DCHECK_RUN_ON was intended instead -
421 RTC_DCHECK(config.event_log != nullptr); 420 RTC_DCHECK(config.event_log != nullptr);
422 RTC_DCHECK_GE(config.bitrate_config.min_bitrate_bps, 0); 421 RTC_DCHECK_GE(config.bitrate_config.min_bitrate_bps, 0);
423 RTC_DCHECK_GE(config.bitrate_config.start_bitrate_bps, 422 RTC_DCHECK_GE(config.bitrate_config.start_bitrate_bps,
424 config.bitrate_config.min_bitrate_bps); 423 config.bitrate_config.min_bitrate_bps);
425 if (config.bitrate_config.max_bitrate_bps != -1) { 424 if (config.bitrate_config.max_bitrate_bps != -1) {
426 RTC_DCHECK_GE(config.bitrate_config.max_bitrate_bps, 425 RTC_DCHECK_GE(config.bitrate_config.max_bitrate_bps,
427 config.bitrate_config.start_bitrate_bps); 426 config.bitrate_config.start_bitrate_bps);
428 } 427 }
429 Trace::CreateTrace(); 428 Trace::CreateTrace();
430 transport_send->send_side_cc()->RegisterNetworkObserver(this); 429 transport_send->send_side_cc()->RegisterNetworkObserver(this);
(...skipping 987 matching lines...) Expand 10 before | Expand all | Expand 10 after
1418 (use_send_side_bwe && header.extension.hasTransportSequenceNumber)) { 1417 (use_send_side_bwe && header.extension.hasTransportSequenceNumber)) {
1419 receive_side_cc_.OnReceivedPacket( 1418 receive_side_cc_.OnReceivedPacket(
1420 packet.arrival_time_ms(), packet.payload_size() + packet.padding_size(), 1419 packet.arrival_time_ms(), packet.payload_size() + packet.padding_size(),
1421 header); 1420 header);
1422 } 1421 }
1423 } 1422 }
1424 1423
1425 } // namespace internal 1424 } // namespace internal
1426 1425
1427 } // namespace webrtc 1426 } // namespace webrtc
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698