Make Port (and subclasses) fully "Network"-based, instead of IP-based.

Make Port (and subclasses) fully "Network"-based, instead of IP-based.

For ICE, we want sockets that are bound to specific network interfaces,
rather than to specific IP addresses. So, a while ago, we added a
"Network" class that gets passed into the Port constructor, in
addition to the IP address as before.

But we never finished the job of removing the IP address field, such that
a Port only guarantees something about the network interface it's
associated with, and not the specific IP address it ends up with.

This CL does that, and as a consequence, if a port ends up bound to
an IP address other than the "best" one (returned by Network::GetBestIP),
this *won't* be treated as an error.

This is relevant to Android, where even though we pass an IP address
into "Bind" as a way of identifying the network, the socket actually
gets bound using "android_setsocknetwork", which doesn't provide any
guarantees about the IP address. So, if a network interface has multiple
IPv6 addresses (for instance), we may not correctly predict the one
the OS will choose, and that's ok.

This CL also moves "SetAlternateLocalAddress" from VirtualSocket to
VirtualSocketServer, which makes for much more readable test code.

The next step, if there is one, is to pass along the Network class all
the way to SocketServer::Bind. Then the socket server could do smart
things with the network information. We could even stick a platform-
specific network handle in the Network object, such that the socket
server could use it for the binding, or for "sendmsg", for example.
See bug 7026 for more context about the sendmsg idea.

BUG=webrtc:7715
Review-Url: https://codereview.webrtc.org/2989303002
Cr-Commit-Position: refs/heads/master@{#19251}
Committed: https://chromium.googlesource.com/external/webrtc/+/5c3c104ba0f843b9c46a921c8d6c2bd6c068acd2

[Taylor Brandstetter, 2017-08-02 22:19:03]

Description was changed from

==========
Make tests pass.


Fixing tests and the whole "SetAlternateLocalAddress" mess.


Merge branch 'master' into socket_bound_to_unexpected_addr


Removing IP from more places, making tests work.


Started doing some stuff. Realized it's more of a mess than I thought.

BUG=
==========

to

==========
Make Port (and subclasses) "Network"-based, instead of IP-based.

For ICE, we want sockets that are bound to specific network interfaces,
rather than to specific IP addresses. So, a while ago, we added a
"Network" class that gets passed into the Port constructor, in
addition to the IP address as before.

But we never finished the job of removing the IP address field, such that
a Port only guarantees something about the network interface it's
associated with, and not the specific IP address it ends up with.

This CL does that, and as a consequence, if a port ends up bound to
an IP address other than the "best" one (returned by Network::GetBestIP),
this *won't* be treated as an error.

This is relevant to Android, where even though we pass an IP address
into "Bind" as a way of identifying the network, the socket actually
gets bound using "android_setsocknetwork", which doesn't provide any
guarantees about the IP address. So, if a network interface has multiple
IPv6 addresses (for instance), we may not correctly predict the one
the OS will choose, and that's ok.

This CL also moves "SetAlternateLocalAddress" from VirtualSocket to
VirtualSocketServer, which makes for much more readable test code.

BUG=webrtc:7715
==========

[Taylor Brandstetter, 2017-08-02 22:19:17]

Description was changed from

==========
Make Port (and subclasses) "Network"-based, instead of IP-based.

For ICE, we want sockets that are bound to specific network interfaces,
rather than to specific IP addresses. So, a while ago, we added a
"Network" class that gets passed into the Port constructor, in
addition to the IP address as before.

But we never finished the job of removing the IP address field, such that
a Port only guarantees something about the network interface it's
associated with, and not the specific IP address it ends up with.

This CL does that, and as a consequence, if a port ends up bound to
an IP address other than the "best" one (returned by Network::GetBestIP),
this *won't* be treated as an error.

This is relevant to Android, where even though we pass an IP address
into "Bind" as a way of identifying the network, the socket actually
gets bound using "android_setsocknetwork", which doesn't provide any
guarantees about the IP address. So, if a network interface has multiple
IPv6 addresses (for instance), we may not correctly predict the one
the OS will choose, and that's ok.

This CL also moves "SetAlternateLocalAddress" from VirtualSocket to
VirtualSocketServer, which makes for much more readable test code.

BUG=webrtc:7715
==========

to

==========
Make Port (and subclasses) fully "Network"-based, instead of IP-based.

For ICE, we want sockets that are bound to specific network interfaces,
rather than to specific IP addresses. So, a while ago, we added a
"Network" class that gets passed into the Port constructor, in
addition to the IP address as before.

But we never finished the job of removing the IP address field, such that
a Port only guarantees something about the network interface it's
associated with, and not the specific IP address it ends up with.

This CL does that, and as a consequence, if a port ends up bound to
an IP address other than the "best" one (returned by Network::GetBestIP),
this *won't* be treated as an error.

This is relevant to Android, where even though we pass an IP address
into "Bind" as a way of identifying the network, the socket actually
gets bound using "android_setsocknetwork", which doesn't provide any
guarantees about the IP address. So, if a network interface has multiple
IPv6 addresses (for instance), we may not correctly predict the one
the OS will choose, and that's ok.

This CL also moves "SetAlternateLocalAddress" from VirtualSocket to
VirtualSocketServer, which makes for much more readable test code.

BUG=webrtc:7715
==========

[Taylor Brandstetter, 2017-08-02 22:22:26]

Description was changed from

==========
Make Port (and subclasses) fully "Network"-based, instead of IP-based.

For ICE, we want sockets that are bound to specific network interfaces,
rather than to specific IP addresses. So, a while ago, we added a
"Network" class that gets passed into the Port constructor, in
addition to the IP address as before.

But we never finished the job of removing the IP address field, such that
a Port only guarantees something about the network interface it's
associated with, and not the specific IP address it ends up with.

This CL does that, and as a consequence, if a port ends up bound to
an IP address other than the "best" one (returned by Network::GetBestIP),
this *won't* be treated as an error.

This is relevant to Android, where even though we pass an IP address
into "Bind" as a way of identifying the network, the socket actually
gets bound using "android_setsocknetwork", which doesn't provide any
guarantees about the IP address. So, if a network interface has multiple
IPv6 addresses (for instance), we may not correctly predict the one
the OS will choose, and that's ok.

This CL also moves "SetAlternateLocalAddress" from VirtualSocket to
VirtualSocketServer, which makes for much more readable test code.

BUG=webrtc:7715
==========

to

==========
Make Port (and subclasses) fully "Network"-based, instead of IP-based.

For ICE, we want sockets that are bound to specific network interfaces,
rather than to specific IP addresses. So, a while ago, we added a
"Network" class that gets passed into the Port constructor, in
addition to the IP address as before.

But we never finished the job of removing the IP address field, such that
a Port only guarantees something about the network interface it's
associated with, and not the specific IP address it ends up with.

This CL does that, and as a consequence, if a port ends up bound to
an IP address other than the "best" one (returned by Network::GetBestIP),
this *won't* be treated as an error.

This is relevant to Android, where even though we pass an IP address
into "Bind" as a way of identifying the network, the socket actually
gets bound using "android_setsocknetwork", which doesn't provide any
guarantees about the IP address. So, if a network interface has multiple
IPv6 addresses (for instance), we may not correctly predict the one
the OS will choose, and that's ok.

This CL also moves "SetAlternateLocalAddress" from VirtualSocket to
VirtualSocketServer, which makes for much more readable test code.

The next step, if there is one, is to pass along the Network class all
the way to SocketServer::Bind. Then the socket server could do smart
things with the network information. We could even stick a platform-
specific network handle in the Network object, such that the socket
server could use it for the binding, or for "sendmsg", for example.
See bug 7026 for more context about the sendmsg idea.

BUG=webrtc:7715
==========

[Taylor Brandstetter, 2017-08-02 22:24:30]

deadbeef@webrtc.org changed reviewers:
+ zhihuang@webrtc.org

[Taylor Brandstetter, 2017-08-02 22:24:31]

PTAL Zhi. This fixes an issue where we may discard an ICE candidate on Android
if the OS doesn't give us the IP address we expect (which shouldn't be treated
as an error, as long as we still get the right network interface).

[Zhi Huang, 2017-08-03 04:07:11]

lgtm with a minor comment.

https://codereview.webrtc.org/2989303002/diff/20001/webrtc/p2p/base/tcpport.cc
File webrtc/p2p/base/tcpport.cc (right):

https://codereview.webrtc.org/2989303002/diff/20001/webrtc/p2p/base/tcpport.c...
webrtc/p2p/base/tcpport.cc:405: //
Maybe add some comments about two special use cases?

[Taylor Brandstetter, 2017-08-03 16:11:03]

https://codereview.webrtc.org/2989303002/diff/20001/webrtc/p2p/base/tcpport.cc
File webrtc/p2p/base/tcpport.cc (right):

https://codereview.webrtc.org/2989303002/diff/20001/webrtc/p2p/base/tcpport.c...
webrtc/p2p/base/tcpport.cc:405: //
On 2017/08/03 04:07:11, Zhi Huang wrote:
> Maybe add some comments about two special use cases?

You mean the comment that's in turnport.cc but not this file? If so, done.

[Taylor Brandstetter, 2017-08-04 21:16:26]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-08-04 21:16:27]

The patchset sent to the CQ was uploaded after l-g-t-m from zhihuang@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2989303002/#ps60001 (title:
"Add back Port constructor that takes IP for backwards compatibility.")

[commit-bot: I haz the power, 2017-08-04 21:16:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-08-04 22:01:57]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1501881386982550,
"parent_rev": "d48f56de1f06d62fcb46bb9f20bd5f336e80aae9", "commit_rev":
"5c3c104ba0f843b9c46a921c8d6c2bd6c068acd2"}

[commit-bot: I haz the power, 2017-08-04 22:02:04]

Description was changed from

==========
Make Port (and subclasses) fully "Network"-based, instead of IP-based.

For ICE, we want sockets that are bound to specific network interfaces,
rather than to specific IP addresses. So, a while ago, we added a
"Network" class that gets passed into the Port constructor, in
addition to the IP address as before.

But we never finished the job of removing the IP address field, such that
a Port only guarantees something about the network interface it's
associated with, and not the specific IP address it ends up with.

This CL does that, and as a consequence, if a port ends up bound to
an IP address other than the "best" one (returned by Network::GetBestIP),
this *won't* be treated as an error.

This is relevant to Android, where even though we pass an IP address
into "Bind" as a way of identifying the network, the socket actually
gets bound using "android_setsocknetwork", which doesn't provide any
guarantees about the IP address. So, if a network interface has multiple
IPv6 addresses (for instance), we may not correctly predict the one
the OS will choose, and that's ok.

This CL also moves "SetAlternateLocalAddress" from VirtualSocket to
VirtualSocketServer, which makes for much more readable test code.

The next step, if there is one, is to pass along the Network class all
the way to SocketServer::Bind. Then the socket server could do smart
things with the network information. We could even stick a platform-
specific network handle in the Network object, such that the socket
server could use it for the binding, or for "sendmsg", for example.
See bug 7026 for more context about the sendmsg idea.

BUG=webrtc:7715
==========

to

==========
Make Port (and subclasses) fully "Network"-based, instead of IP-based.

For ICE, we want sockets that are bound to specific network interfaces,
rather than to specific IP addresses. So, a while ago, we added a
"Network" class that gets passed into the Port constructor, in
addition to the IP address as before.

But we never finished the job of removing the IP address field, such that
a Port only guarantees something about the network interface it's
associated with, and not the specific IP address it ends up with.

This CL does that, and as a consequence, if a port ends up bound to
an IP address other than the "best" one (returned by Network::GetBestIP),
this *won't* be treated as an error.

This is relevant to Android, where even though we pass an IP address
into "Bind" as a way of identifying the network, the socket actually
gets bound using "android_setsocknetwork", which doesn't provide any
guarantees about the IP address. So, if a network interface has multiple
IPv6 addresses (for instance), we may not correctly predict the one
the OS will choose, and that's ok.

This CL also moves "SetAlternateLocalAddress" from VirtualSocket to
VirtualSocketServer, which makes for much more readable test code.

The next step, if there is one, is to pass along the Network class all
the way to SocketServer::Bind. Then the socket server could do smart
things with the network information. We could even stick a platform-
specific network handle in the Network object, such that the socket
server could use it for the binding, or for "sendmsg", for example.
See bug 7026 for more context about the sendmsg idea.

BUG=webrtc:7715

Review-Url: https://codereview.webrtc.org/2989303002
Cr-Commit-Position: refs/heads/master@{#19251}
Committed:
https://chromium.googlesource.com/external/webrtc/+/5c3c104ba0f843b9c46a921c8...
==========

[commit-bot: I haz the power, 2017-08-04 22:02:05]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/webrtc/+/5c3c104ba0f843b9c46a921c8...