Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: webrtc/p2p/base/turnport.h

Issue 2989303002: Make Port (and subclasses) fully "Network"-based, instead of IP-based. (Closed)
Patch Set: Add back Port constructor that takes IP for backwards compatibility. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/base/tcpport_unittest.cc ('k') | webrtc/p2p/base/turnport.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/turnport.h
diff --git a/webrtc/p2p/base/turnport.h b/webrtc/p2p/base/turnport.h
index 4e4d4b17743a36dbf9bbbae424f732d9ffb4ea6f..abdaa3dcb433b7f1d508a2a229e8240db445251e 100644
--- a/webrtc/p2p/base/turnport.h
+++ b/webrtc/p2p/base/turnport.h
@@ -42,6 +42,7 @@ class TurnPort : public Port {
STATE_DISCONNECTED, // TCP connection died, cannot send/receive any
// packets.
};
+ // Create a TURN port using the shared UDP socket, |socket|.
static TurnPort* Create(rtc::Thread* thread,
rtc::PacketSocketFactory* factory,
rtc::Network* network,
@@ -56,10 +57,11 @@ class TurnPort : public Port {
server_address, credentials, server_priority, origin);
}
+ // Create a TURN port that will use a new socket, bound to |network| and
+ // using a port in the range between |min_port| and |max_port|.
static TurnPort* Create(rtc::Thread* thread,
rtc::PacketSocketFactory* factory,
rtc::Network* network,
- const rtc::IPAddress& ip,
uint16_t min_port,
uint16_t max_port,
const std::string& username, // ice username.
@@ -68,9 +70,9 @@ class TurnPort : public Port {
const RelayCredentials& credentials,
int server_priority,
const std::string& origin) {
- return new TurnPort(thread, factory, network, ip, min_port, max_port,
- username, password, server_address, credentials,
- server_priority, origin);
+ return new TurnPort(thread, factory, network, min_port, max_port, username,
+ password, server_address, credentials, server_priority,
+ origin);
}
virtual ~TurnPort();
@@ -177,7 +179,6 @@ class TurnPort : public Port {
TurnPort(rtc::Thread* thread,
rtc::PacketSocketFactory* factory,
rtc::Network* network,
- const rtc::IPAddress& ip,
uint16_t min_port,
uint16_t max_port,
const std::string& username,
« no previous file with comments | « webrtc/p2p/base/tcpport_unittest.cc ('k') | webrtc/p2p/base/turnport.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698