Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: webrtc/p2p/base/stunport.h

Issue 2989303002: Make Port (and subclasses) fully "Network"-based, instead of IP-based. (Closed)
Patch Set: Add back Port constructor that takes IP for backwards compatibility. Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/base/relayport_unittest.cc ('k') | webrtc/p2p/base/stunport.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/stunport.h
diff --git a/webrtc/p2p/base/stunport.h b/webrtc/p2p/base/stunport.h
index de5127c67156e9ec1b9a47d4910a74e2ac4e3b09..8fbc0d52fa46459bb90433626085373dbe9329cd 100644
--- a/webrtc/p2p/base/stunport.h
+++ b/webrtc/p2p/base/stunport.h
@@ -54,7 +54,6 @@ class UDPPort : public Port {
static UDPPort* Create(rtc::Thread* thread,
rtc::PacketSocketFactory* factory,
rtc::Network* network,
- const rtc::IPAddress& ip,
uint16_t min_port,
uint16_t max_port,
const std::string& username,
@@ -62,7 +61,7 @@ class UDPPort : public Port {
const std::string& origin,
bool emit_local_for_anyaddress) {
UDPPort* port =
- new UDPPort(thread, factory, network, ip, min_port, max_port, username,
+ new UDPPort(thread, factory, network, min_port, max_port, username,
password, origin, emit_local_for_anyaddress);
if (!port->Init()) {
delete port;
@@ -127,7 +126,6 @@ class UDPPort : public Port {
UDPPort(rtc::Thread* thread,
rtc::PacketSocketFactory* factory,
rtc::Network* network,
- const rtc::IPAddress& ip,
uint16_t min_port,
uint16_t max_port,
const std::string& username,
@@ -259,17 +257,14 @@ class StunPort : public UDPPort {
static StunPort* Create(rtc::Thread* thread,
rtc::PacketSocketFactory* factory,
rtc::Network* network,
- const rtc::IPAddress& ip,
uint16_t min_port,
uint16_t max_port,
const std::string& username,
const std::string& password,
const ServerAddresses& servers,
const std::string& origin) {
- StunPort* port = new StunPort(thread, factory, network,
- ip, min_port, max_port,
- username, password, servers,
- origin);
+ StunPort* port = new StunPort(thread, factory, network, min_port, max_port,
+ username, password, servers, origin);
if (!port->Init()) {
delete port;
port = NULL;
@@ -287,7 +282,6 @@ class StunPort : public UDPPort {
StunPort(rtc::Thread* thread,
rtc::PacketSocketFactory* factory,
rtc::Network* network,
- const rtc::IPAddress& ip,
uint16_t min_port,
uint16_t max_port,
const std::string& username,
@@ -297,7 +291,6 @@ class StunPort : public UDPPort {
: UDPPort(thread,
factory,
network,
- ip,
min_port,
max_port,
username,
« no previous file with comments | « webrtc/p2p/base/relayport_unittest.cc ('k') | webrtc/p2p/base/stunport.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698