Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2987253003: ObjC: Add implementationName for injectable codecs (Closed)

Created:
3 years, 4 months ago by magjed_webrtc
Modified:
3 years, 4 months ago
Reviewers:
andersc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

ObjC: Add implementationName for injectable codecs BUG=webrtc:7924 Review-Url: https://codereview.webrtc.org/2987253003 Cr-Commit-Position: refs/heads/master@{#19213} Committed: https://chromium.googlesource.com/external/webrtc/+/5805c9dbda6955b259439e636c5963254828a164

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -6 lines) Patch
M webrtc/sdk/objc/Framework/Classes/PeerConnection/RTCVideoCodecH264.mm View 2 chunks +8 lines, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm View 3 chunks +6 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm View 3 chunks +8 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Headers/WebRTC/RTCVideoCodec.h View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
magjed_webrtc
Anders - please take a look.
3 years, 4 months ago (2017-08-01 15:18:13 UTC) #5
andersc
lgtm
3 years, 4 months ago (2017-08-01 21:44:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2987253003/1
3 years, 4 months ago (2017-08-02 12:23:27 UTC) #10
commit-bot: I haz the power
3 years, 4 months ago (2017-08-02 12:26:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5805c9dbda6955b259439e636...

Powered by Google App Engine
This is Rietveld 408576698