Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm

Issue 2987253003: ObjC: Add implementationName for injectable codecs (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm
diff --git a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm
index c6e11c841574e1639802eaffa8c9d75678ae7450..f6e6ff55ac1d7a0b422e06272b3149db58f46d23 100644
--- a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm
+++ b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.mm
@@ -10,6 +10,7 @@
#include "webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_decoder_factory.h"
+#import "NSString+StdString.h"
#import "RTCVideoCodec+Private.h"
#import "WebRTC/RTCVideoCodec.h"
#import "WebRTC/RTCVideoCodecFactory.h"
@@ -30,7 +31,8 @@ namespace webrtc {
namespace {
class ObjCVideoDecoder : public VideoDecoder {
public:
- ObjCVideoDecoder(id<RTCVideoDecoder> decoder) : decoder_(decoder) {}
+ ObjCVideoDecoder(id<RTCVideoDecoder> decoder)
+ : decoder_(decoder), implementation_name_([decoder implementationName].stdString) {}
~ObjCVideoDecoder() { [decoder_ destroy]; }
int32_t InitDecode(const VideoCodec *codec_settings, int32_t number_of_cores) {
@@ -85,8 +87,11 @@ class ObjCVideoDecoder : public VideoDecoder {
int32_t Release() { return [decoder_ releaseDecoder]; }
+ const char *ImplementationName() const { return implementation_name_.c_str(); }
+
private:
id<RTCVideoDecoder> decoder_;
+ const std::string implementation_name_;
};
} // namespace

Powered by Google App Engine
This is Rietveld 408576698