Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Unified Diff: webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm

Issue 2987253003: ObjC: Add implementationName for injectable codecs (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm
diff --git a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm
index 0472fc07ae2a8939430801efe0a5ba8beee1af01..ecdc716d85297714c37486f40a6810bf38baf817 100644
--- a/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm
+++ b/webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.mm
@@ -10,6 +10,9 @@
#include "webrtc/sdk/objc/Framework/Classes/VideoToolbox/objc_video_encoder_factory.h"
+#include <string>
+
+#import "NSString+StdString.h"
#import "RTCVideoCodec+Private.h"
#import "WebRTC/RTCVideoCodec.h"
#import "WebRTC/RTCVideoCodecFactory.h"
@@ -32,7 +35,8 @@ namespace webrtc {
namespace {
class ObjCVideoEncoder : public VideoEncoder {
public:
- ObjCVideoEncoder(id<RTCVideoEncoder> encoder) : encoder_(encoder) {}
+ ObjCVideoEncoder(id<RTCVideoEncoder> encoder)
+ : encoder_(encoder), implementation_name_([encoder implementationName].stdString) {}
~ObjCVideoEncoder() { [encoder_ destroy]; }
int32_t InitEncode(const VideoCodec *codec_settings,
@@ -118,8 +122,11 @@ class ObjCVideoEncoder : public VideoEncoder {
ScalingSettings(false /* enabled */);
}
+ const char *ImplementationName() const { return implementation_name_.c_str(); }
+
private:
id<RTCVideoEncoder> encoder_;
+ const std::string implementation_name_;
};
} // namespace

Powered by Google App Engine
This is Rietveld 408576698