Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2980923002: SignalPacketReceived should pass packet as a pointer instead of a non-const reference. (Closed)

Created:
3 years, 5 months ago by Zach Stein
Modified:
3 years, 5 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

SignalPacketReceived should pass packet as a pointer instead of a non-const reference. See https://google.github.io/styleguide/cppguide.html#Reference_Arguments. The Bind to ProcessPacket in OnPacketReceived is safe because Bind captures arguments by value. BUG=webrtc:7013 Review-Url: https://codereview.webrtc.org/2980923002 Cr-Commit-Position: refs/heads/master@{#19028} Committed: https://chromium.googlesource.com/external/webrtc/+/634977b61107244a24652120b762fdce23eb5cb9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -11 lines) Patch
M webrtc/pc/channel.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/pc/channel.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M webrtc/pc/rtptransport.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/rtptransport.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/pc/rtptransport_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
Zach Stein
PTAL
3 years, 5 months ago (2017-07-13 22:03:17 UTC) #3
Taylor Brandstetter
lgtm
3 years, 5 months ago (2017-07-13 23:47:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2980923002/1
3 years, 5 months ago (2017-07-14 18:46:13 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-07-14 19:30:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/634977b61107244a24652120b...

Powered by Google App Engine
This is Rietveld 408576698