Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1587)

Side by Side Diff: webrtc/pc/rtptransport.h

Issue 2980923002: SignalPacketReceived should pass packet as a pointer instead of a non-const reference. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/pc/channel.cc ('k') | webrtc/pc/rtptransport.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 const rtc::PacketOptions& options, 66 const rtc::PacketOptions& options,
67 int flags); 67 int flags);
68 68
69 bool HandlesPayloadType(int payload_type) const; 69 bool HandlesPayloadType(int payload_type) const;
70 70
71 void AddHandledPayloadType(int payload_type); 71 void AddHandledPayloadType(int payload_type);
72 72
73 // TODO(zstein): Consider having two signals - RtcPacketReceived and 73 // TODO(zstein): Consider having two signals - RtcPacketReceived and
74 // RtcpPacketReceived. 74 // RtcpPacketReceived.
75 // The first argument is true for RTCP packets and false for RTP packets. 75 // The first argument is true for RTCP packets and false for RTP packets.
76 sigslot::signal3<bool, rtc::CopyOnWriteBuffer&, const rtc::PacketTime&> 76 sigslot::signal3<bool, rtc::CopyOnWriteBuffer*, const rtc::PacketTime&>
77 SignalPacketReceived; 77 SignalPacketReceived;
78 78
79 protected: 79 protected:
80 // TODO(zstein): Remove this when we remove RtpTransportAdapter. 80 // TODO(zstein): Remove this when we remove RtpTransportAdapter.
81 RtpTransportAdapter* GetInternal() override; 81 RtpTransportAdapter* GetInternal() override;
82 82
83 private: 83 private:
84 bool HandlesPacket(const uint8_t* data, size_t len); 84 bool HandlesPacket(const uint8_t* data, size_t len);
85 85
86 void OnReadyToSend(rtc::PacketTransportInternal* transport); 86 void OnReadyToSend(rtc::PacketTransportInternal* transport);
(...skipping 22 matching lines...) Expand all
109 bool rtcp_ready_to_send_ = false; 109 bool rtcp_ready_to_send_ = false;
110 110
111 RtcpParameters rtcp_parameters_; 111 RtcpParameters rtcp_parameters_;
112 112
113 cricket::BundleFilter bundle_filter_; 113 cricket::BundleFilter bundle_filter_;
114 }; 114 };
115 115
116 } // namespace webrtc 116 } // namespace webrtc
117 117
118 #endif // WEBRTC_PC_RTPTRANSPORT_H_ 118 #endif // WEBRTC_PC_RTPTRANSPORT_H_
OLDNEW
« no previous file with comments | « webrtc/pc/channel.cc ('k') | webrtc/pc/rtptransport.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698