Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Side by Side Diff: webrtc/pc/rtptransport_unittest.cc

Issue 2980923002: SignalPacketReceived should pass packet as a pointer instead of a non-const reference. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/pc/rtptransport.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2017 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2017 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 144 matching lines...) Expand 10 before | Expand all | Expand 10 after
155 public: 155 public:
156 explicit SignalPacketReceivedCounter(RtpTransport* transport) { 156 explicit SignalPacketReceivedCounter(RtpTransport* transport) {
157 transport->SignalPacketReceived.connect( 157 transport->SignalPacketReceived.connect(
158 this, &SignalPacketReceivedCounter::OnPacketReceived); 158 this, &SignalPacketReceivedCounter::OnPacketReceived);
159 } 159 }
160 int rtcp_count() const { return rtcp_count_; } 160 int rtcp_count() const { return rtcp_count_; }
161 int rtp_count() const { return rtp_count_; } 161 int rtp_count() const { return rtp_count_; }
162 162
163 private: 163 private:
164 void OnPacketReceived(bool rtcp, 164 void OnPacketReceived(bool rtcp,
165 rtc::CopyOnWriteBuffer&, 165 rtc::CopyOnWriteBuffer*,
166 const rtc::PacketTime&) { 166 const rtc::PacketTime&) {
167 if (rtcp) { 167 if (rtcp) {
168 ++rtcp_count_; 168 ++rtcp_count_;
169 } else { 169 } else {
170 ++rtp_count_; 170 ++rtp_count_;
171 } 171 }
172 } 172 }
173 int rtcp_count_ = 0; 173 int rtcp_count_ = 0;
174 int rtp_count_ = 0; 174 int rtp_count_ = 0;
175 }; 175 };
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 227
228 const rtc::PacketOptions options; 228 const rtc::PacketOptions options;
229 const int flags = 0; 229 const int flags = 0;
230 rtc::Buffer rtp_data(kRtpData, kRtpLen); 230 rtc::Buffer rtp_data(kRtpData, kRtpLen);
231 fake_rtp.SendPacket(rtp_data.data<char>(), kRtpLen, options, flags); 231 fake_rtp.SendPacket(rtp_data.data<char>(), kRtpLen, options, flags);
232 EXPECT_EQ(0, observer.rtp_count()); 232 EXPECT_EQ(0, observer.rtp_count());
233 EXPECT_EQ(0, observer.rtcp_count()); 233 EXPECT_EQ(0, observer.rtcp_count());
234 } 234 }
235 235
236 } // namespace webrtc 236 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/pc/rtptransport.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698