Fix potential incorrect sync flags used with screenshare TL stream.

Fix potential incorrect sync flags used with screenshare TL stream.

BUG=webrtc:7980
Review-Url: https://codereview.webrtc.org/2978743002
Cr-Commit-Position: refs/heads/master@{#18999}
Committed: https://chromium.googlesource.com/external/webrtc/+/f03ea04176fbdad3d2efb88eb3c6d2edae1c3586

[sprang_webrtc, 2017-07-12 12:27:19]

The CQ bit was checked by sprang@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-12 12:27:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[sprang_webrtc, 2017-07-12 12:27:41]

sprang@webrtc.org changed reviewers:
+ ilnik@webrtc.org, pbos@webrtc.org

[commit-bot: I haz the power, 2017-07-12 12:56:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-12 12:56:55]

Dry run: This issue passed the CQ dry run.

[ilnik, 2017-07-12 13:22:09]

On 2017/07/12 12:27:42, sprang_webrtc wrote:

lgtm

[pbos-webrtc, 2017-07-12 18:05:45]

pbos@webrtc.org changed reviewers:
+ marpan@webrtc.org

[pbos-webrtc, 2017-07-12 18:05:46]

+r marpan@ can you take a look as well?

https://codereview.webrtc.org/2978743002/diff/10002/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp8/temporal_layers.h (right):

https://codereview.webrtc.org/2978743002/diff/10002/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp8/temporal_layers.h:58: bool
operator==(const FrameConfig& o) const {
Where do we need this operator?

[pbos-webrtc, 2017-07-12 18:26:45]

lgtm

https://codereview.webrtc.org/2978743002/diff/10002/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp8/temporal_layers.h (right):

https://codereview.webrtc.org/2978743002/diff/10002/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp8/temporal_layers.h:58: bool
operator==(const FrameConfig& o) const {
On 2017/07/12 18:05:46, pbos-webrtc wrote:
> Where do we need this operator?

.. if we don't, can we delete it?

[marpan, 2017-07-12 19:50:05]

marpan@google.com changed reviewers:
+ marpan@google.com

[marpan, 2017-07-12 19:50:06]

lgtm

[sprang_webrtc, 2017-07-13 10:50:50]

https://codereview.webrtc.org/2978743002/diff/10002/webrtc/modules/video_codi...
File webrtc/modules/video_coding/codecs/vp8/temporal_layers.h (right):

https://codereview.webrtc.org/2978743002/diff/10002/webrtc/modules/video_codi...
webrtc/modules/video_coding/codecs/vp8/temporal_layers.h:58: bool
operator==(const FrameConfig& o) const {
On 2017/07/12 18:26:45, pbos-webrtc wrote:
> On 2017/07/12 18:05:46, pbos-webrtc wrote:
> > Where do we need this operator?
> 
> .. if we don't, can we delete it?

It's used in the test. I could add a comparator in the test suite instead, but
then we risk code duplication and missing changes in this struct, so would
prefer to keep it here.

[sprang_webrtc, 2017-07-13 10:50:57]

The CQ bit was checked by sprang@webrtc.org

[commit-bot: I haz the power, 2017-07-13 10:50:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-07-13 10:53:52]

CQ is committing da patch.

Bot data: {"patchset_id": 10002, "attempt_start_ts": 1499943057368560,
"parent_rev": "d77c446193f7ac0d753bf3552bfd6c3f50913fbc", "commit_rev":
"f03ea04176fbdad3d2efb88eb3c6d2edae1c3586"}

[commit-bot: I haz the power, 2017-07-13 10:54:01]

Description was changed from

==========
Fix potential incorrect sync flags used with screenshare TL stream.

BUG=webrtc:7980
==========

to

==========
Fix potential incorrect sync flags used with screenshare TL stream.

BUG=webrtc:7980

Review-Url: https://codereview.webrtc.org/2978743002
Cr-Commit-Position: refs/heads/master@{#18999}
Committed:
https://chromium.googlesource.com/external/webrtc/+/f03ea04176fbdad3d2efb88eb...
==========

[commit-bot: I haz the power, 2017-07-13 10:54:02]

Committed patchset #2 (id:10002) as
https://chromium.googlesource.com/external/webrtc/+/f03ea04176fbdad3d2efb88eb...