Fix potential incorrect sync flags used with screenshare TL stream.

webrtc/modules/video_coding/codecs/vp8/temporal_layers.h

 /* Copyright (c) 2011 The WebRTC project authors. All Rights Reserved.
 *
 *  Use of this source code is governed by a BSD-style license
 *  that can be found in the LICENSE file in the root of the source
 *  tree. An additional intellectual property rights grant can be found
 *  in the file PATENTS.  All contributing project authors may
 *  be found in the AUTHORS file in the root of the source tree.
 */
 /*
 * This file defines the interface for doing temporal layers with VP8.
@@ skipping 37 matching lines @@
     BufferFlags arf_buffer_flags;
 
     // TODO(pbos): Consider breaking these out of here and returning only a
     // pattern index that needs to be returned to fill CodecSpecificInfoVP8 or
     // EncodeFlags.
     bool layer_sync;
     bool freeze_entropy;
 
     int pattern_idx;
 
+    bool operator==(const FrameConfig& o) const {

[pbos-webrtc, 2017/07/12 18:05:46]

Where do we need this operator?

[pbos-webrtc, 2017/07/12 18:26:45]

.. if we don't, can we delete it?

[sprang_webrtc, 2017/07/13 10:50:50]

It's used in the test. I could add a comparator in the test suite instead, but
then we risk code duplication and missing changes in this struct, so would
prefer to keep it here.

+      return drop_frame == o.drop_frame &&
+             last_buffer_flags == o.last_buffer_flags &&
+             golden_buffer_flags == o.golden_buffer_flags &&
+             arf_buffer_flags == o.arf_buffer_flags &&
+             layer_sync == o.layer_sync && freeze_entropy == o.freeze_entropy &&
+             pattern_idx == o.pattern_idx;
+    }
+    bool operator!=(const FrameConfig& o) const { return !(*this == o); }
+
    private:
     FrameConfig(BufferFlags last,
                 BufferFlags golden,
                 BufferFlags arf,
                 bool freeze_entropy);
   };
 
   // Factory for TemporalLayer strategy. Default behavior is a fixed pattern
   // of temporal layers. See default_temporal_layers.cc
   virtual ~TemporalLayers() {}
@@ skipping 55 matching lines @@
  public:
   TemporalLayersListener() {}
   virtual ~TemporalLayersListener() {}
 
   virtual void OnTemporalLayersCreated(int simulcast_id,
                                        TemporalLayers* layers) = 0;
 };
 
 }  // namespace webrtc
 #endif  // WEBRTC_MODULES_VIDEO_CODING_CODECS_VP8_TEMPORAL_LAYERS_H_