Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: webrtc/modules/video_coding/codecs/vp8/temporal_layers.h

Issue 2978743002: Fix potential incorrect sync flags used with screenshare TL stream. (Closed)
Patch Set: test case, plus frame config constructor fixes Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/codecs/vp8/temporal_layers.h
diff --git a/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h b/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h
index 9b122919380684bf651d35fc7753bda93496c976..b3601e69f0d6aa15ba498d55ce8f436649093eb1 100644
--- a/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h
+++ b/webrtc/modules/video_coding/codecs/vp8/temporal_layers.h
@@ -55,6 +55,16 @@ class TemporalLayers {
int pattern_idx;
+ bool operator==(const FrameConfig& o) const {
pbos-webrtc 2017/07/12 18:05:46 Where do we need this operator?
pbos-webrtc 2017/07/12 18:26:45 .. if we don't, can we delete it?
sprang_webrtc 2017/07/13 10:50:50 It's used in the test. I could add a comparator in
+ return drop_frame == o.drop_frame &&
+ last_buffer_flags == o.last_buffer_flags &&
+ golden_buffer_flags == o.golden_buffer_flags &&
+ arf_buffer_flags == o.arf_buffer_flags &&
+ layer_sync == o.layer_sync && freeze_entropy == o.freeze_entropy &&
+ pattern_idx == o.pattern_idx;
+ }
+ bool operator!=(const FrameConfig& o) const { return !(*this == o); }
+
private:
FrameConfig(BufferFlags last,
BufferFlags golden,
« no previous file with comments | « webrtc/modules/video_coding/codecs/vp8/screenshare_layers_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698