Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2971683002: Changed default value for the duration of the echo in echocanceller 3 (Closed)

Created:
3 years, 5 months ago by peah-webrtc
Modified:
3 years, 5 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Changed default value for the duration of the echo in echocanceller 3 BUG=webrtc:7519 Review-Url: https://codereview.webrtc.org/2971683002 Cr-Commit-Position: refs/heads/master@{#18887} Committed: https://chromium.googlesource.com/external/webrtc/+/2c3161c86e4d96df42ef558dff932baf0b2feb04

Patch Set 1 #

Patch Set 2 : Removed the echo decay as a configuration parameter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M webrtc/modules/audio_processing/aec3/echo_canceller3.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec3/echo_canceller3_unittest.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/echo_remover.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/include/audio_processing.h View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
peah-webrtc
Hi ivoc@, Could you please take a look at this CL?
3 years, 5 months ago (2017-07-04 10:25:13 UTC) #3
peah-webrtc
New patch set.
3 years, 5 months ago (2017-07-04 10:34:37 UTC) #4
ivoc
lgtm
3 years, 5 months ago (2017-07-04 10:51:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2971683002/20001
3 years, 5 months ago (2017-07-04 10:58:25 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-07-04 11:33:17 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/2c3161c86e4d96df42ef558df...

Powered by Google App Engine
This is Rietveld 408576698