webrtc/modules/audio_processing/aec3/echo_canceller3.cc - Issue 2971683002: Changed default value for the duration of the echo in echocanceller 3

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/aec3/echo_canceller3.cc

Issue 2971683002: Changed default value for the duration of the echo in echocanceller 3 (Closed)

Patch Set: Removed the echo decay as a configuration parameter Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_processing/aec3/echo_canceller3.cc

diff --git a/webrtc/modules/audio_processing/aec3/echo_canceller3.cc b/webrtc/modules/audio_processing/aec3/echo_canceller3.cc

index 3175c5414c0ae82295e94cea0f518d80f6049f34..c85116d72c6d1dffd44e5e801dea17cc35d6eb31 100644

--- a/webrtc/modules/audio_processing/aec3/echo_canceller3.cc

+++ b/webrtc/modules/audio_processing/aec3/echo_canceller3.cc

@@ -334,7 +334,7 @@ std::string EchoCanceller3::ToString(

bool EchoCanceller3::Validate(

const AudioProcessing::Config::EchoCanceller3& config) {

- return (config.echo_decay >= 0.f && config.echo_decay < 1.f);

+ return true;

}

void EchoCanceller3::EmptyRenderQueue() {

« no previous file with comments | « no previous file | webrtc/modules/audio_processing/aec3/echo_canceller3_unittest.cc » ('j') | no next file with comments »