Chromium Code Reviews

Unified Diff: webrtc/modules/audio_processing/aec3/echo_canceller3_unittest.cc

Issue 2971683002: Changed default value for the duration of the echo in echocanceller 3 (Closed)
Patch Set: Removed the echo decay as a configuration parameter Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: webrtc/modules/audio_processing/aec3/echo_canceller3_unittest.cc
diff --git a/webrtc/modules/audio_processing/aec3/echo_canceller3_unittest.cc b/webrtc/modules/audio_processing/aec3/echo_canceller3_unittest.cc
index 376cf1edfbd54810c2742ec00411b022933dd447..3a4550077da0b28d8652b118edffecaf7ccceb79 100644
--- a/webrtc/modules/audio_processing/aec3/echo_canceller3_unittest.cc
+++ b/webrtc/modules/audio_processing/aec3/echo_canceller3_unittest.cc
@@ -684,17 +684,7 @@ TEST(EchoCanceller3Messaging, EchoLeakage) {
TEST(EchoCanceller3, ConfigValidation) {
AudioProcessing::Config::EchoCanceller3 config;
-
- config.echo_decay = 0.f;
- EXPECT_TRUE(EchoCanceller3::Validate(config));
- config.echo_decay = 0.9f;
EXPECT_TRUE(EchoCanceller3::Validate(config));
- config.echo_decay = -0.1f;
- EXPECT_FALSE(EchoCanceller3::Validate(config));
- config.echo_decay = 1.0f;
- EXPECT_FALSE(EchoCanceller3::Validate(config));
- config.echo_decay = 1.1f;
- EXPECT_FALSE(EchoCanceller3::Validate(config));
}
#if RTC_DCHECK_IS_ON && GTEST_HAS_DEATH_TEST && !defined(WEBRTC_ANDROID)
« no previous file with comments | « webrtc/modules/audio_processing/aec3/echo_canceller3.cc ('k') | webrtc/modules/audio_processing/aec3/echo_remover.cc » ('j') | no next file with comments »

Powered by Google App Engine