Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2930853002: Reland of Conversational speech tool, simualtor + unit tests (Closed)

Created:
3 years, 6 months ago by AleBzk
Modified:
3 years, 6 months ago
Reviewers:
charujain
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Conversational speech tool, simualtor + unit tests (patchset #1 id:1 of https://codereview.webrtc.org/2925123003/ ) Reason for revert: Build file causing google3 compilation error fixed Original issue's description: > Revert of Conversational speech tool, simualtor + unit tests (patchset #12 id:220001 of https://codereview.webrtc.org/2790933002/ ) > > Reason for revert: > Compile Error. > > Original issue's description: > > The simulator puts into action the schedule of speech turns encoded in a MultiEndCall instance. The output is a set of audio track pairs. There is one set for each speaker and each set contains one near-end and one far-end audio track. The tracks are directly written into wav files instead of creating them in memory. To speed up the creation of the output wav files, *all* the source audio tracks (i.e., the atomic speech turns) are pre-loaded. > > > > The ConversationalSpeechTest.MultiEndCallSimulator unit test defines a conversational speech sequence and creates two wav files (with pure tones at 440 and 880 Hz) that are used as atomic speech turn tracks. > > > > This CL also patches MultiEndCall in order to allow input audio tracks with same sample rate and single channel only. > > > > BUG=webrtc:7218 > > > > Review-Url: https://codereview.webrtc.org/2790933002 > > Cr-Commit-Position: refs/heads/master@{#18480} > > Committed: https://chromium.googlesource.com/external/webrtc/+/6b648c4697cede14605fd2b89425866eec5f7c79 > > TBR=minyue@webrtc.org,alessiob@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:7218 > > Review-Url: https://codereview.webrtc.org/2925123003 > Cr-Commit-Position: refs/heads/master@{#18481} > Committed: https://chromium.googlesource.com/external/webrtc/+/4c72cf43dfda9255468102ce4b4c520571d8f455 TBR=minyue@webrtc.org,charujain@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7218 Review-Url: https://codereview.webrtc.org/2930853002 Cr-Commit-Position: refs/heads/master@{#18606} Committed: https://chromium.googlesource.com/external/webrtc/+/f9784f23d7b95db426626c340690f7592a1a7f46

Patch Set 1 #

Total comments: 1

Patch Set 2 : build file fixed #

Patch Set 3 : ConversationalSpeechTest.MultiEndCallSimulator disabled #

Patch Set 4 : merge #

Messages

Total messages: 10 (5 generated)
AleBzk
Created Reland of Conversational speech tool, simualtor + unit tests
3 years, 6 months ago (2017-06-08 07:43:32 UTC) #1
AleBzk
Hi Charu, I finally fixed my CL and I'm ready to reland. PTAL. Cheers, Alessio ...
3 years, 6 months ago (2017-06-14 08:34:08 UTC) #4
charujain
lgtm
3 years, 6 months ago (2017-06-15 09:05:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2930853002/180001
3 years, 6 months ago (2017-06-15 09:24:56 UTC) #7
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 09:25:06 UTC) #10
Message was sent while issue was closed.
Committed patchset #4 (id:180001) as
https://chromium.googlesource.com/external/webrtc/+/f9784f23d7b95db426626c340...

Powered by Google App Engine
This is Rietveld 408576698