Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2925123003: Revert of Conversational speech tool, simualtor + unit tests (Closed)

Created:
3 years, 6 months ago by charujain
Modified:
3 years, 6 months ago
Reviewers:
AleBzk, minyue-webrtc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Conversational speech tool, simualtor + unit tests (patchset #12 id:220001 of https://codereview.webrtc.org/2790933002/ ) Reason for revert: Compile Error. Original issue's description: > The simulator puts into action the schedule of speech turns encoded in a MultiEndCall instance. The output is a set of audio track pairs. There is one set for each speaker and each set contains one near-end and one far-end audio track. The tracks are directly written into wav files instead of creating them in memory. To speed up the creation of the output wav files, *all* the source audio tracks (i.e., the atomic speech turns) are pre-loaded. > > The ConversationalSpeechTest.MultiEndCallSimulator unit test defines a conversational speech sequence and creates two wav files (with pure tones at 440 and 880 Hz) that are used as atomic speech turn tracks. > > This CL also patches MultiEndCall in order to allow input audio tracks with same sample rate and single channel only. > > BUG=webrtc:7218 > > Review-Url: https://codereview.webrtc.org/2790933002 > Cr-Commit-Position: refs/heads/master@{#18480} > Committed: https://chromium.googlesource.com/external/webrtc/+/6b648c4697cede14605fd2b89425866eec5f7c79 TBR=minyue@webrtc.org,alessiob@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7218 Review-Url: https://codereview.webrtc.org/2925123003 Cr-Commit-Position: refs/heads/master@{#18481} Committed: https://chromium.googlesource.com/external/webrtc/+/4c72cf43dfda9255468102ce4b4c520571d8f455

Patch Set 1 #

Messages

Total messages: 7 (3 generated)
charujain
Created Revert of Conversational speech tool, simualtor + unit tests
3 years, 6 months ago (2017-06-07 18:58:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2925123003/1
3 years, 6 months ago (2017-06-07 18:59:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/4c72cf43dfda9255468102ce4b4c520571d8f455
3 years, 6 months ago (2017-06-07 18:59:14 UTC) #6
AleBzk
3 years, 6 months ago (2017-06-08 07:43:31 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2930853002/ by alessiob@webrtc.org.

The reason for reverting is: google3 compilation error fix.

Powered by Google App Engine
This is Rietveld 408576698