Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2808053002: Conversational Speech tool completed (Closed)

Created:
3 years, 8 months ago by AleBzk
Modified:
3 years, 6 months ago
Reviewers:
hlundin-webrtc, hlundin
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

This CL finalizes the Conversational Speech tool. The following changes have been made: - command line args wired, - user output added, - final polishing. BUG=webrtc:7218 Review-Url: https://codereview.webrtc.org/2808053002 Cr-Commit-Position: refs/heads/master@{#18609} Committed: https://chromium.googlesource.com/external/webrtc/+/19e087fc91453b761b6b56ba84e7c9c5fafd9e8e

Patch Set 1 #

Patch Set 2 : Conversational Speech tool finalized #

Patch Set 3 : output for the user added #

Total comments: 1

Patch Set 4 : typo fixed #

Patch Set 5 : merge #

Patch Set 6 : merge #

Messages

Total messages: 17 (13 generated)
AleBzk
Hi Henrik, This should be the last CL on the conversational speech tool. As agreed, ...
3 years, 8 months ago (2017-04-11 09:20:44 UTC) #4
hlundin-webrtc
LGTM with one nit. https://codereview.webrtc.org/2808053002/diff/40001/webrtc/modules/audio_processing/test/conversational_speech/generator.cc File webrtc/modules/audio_processing/test/conversational_speech/generator.cc (right): https://codereview.webrtc.org/2808053002/diff/40001/webrtc/modules/audio_processing/test/conversational_speech/generator.cc#newcode68 webrtc/modules/audio_processing/test/conversational_speech/generator.cc:68: auto generated_audiotrak_pairs = conversational_speech::Simulate( audiotrak ...
3 years, 8 months ago (2017-04-11 10:29:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2808053002/120001
3 years, 6 months ago (2017-06-15 10:47:57 UTC) #14
commit-bot: I haz the power
3 years, 6 months ago (2017-06-15 10:50:02 UTC) #17
Message was sent while issue was closed.
Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/external/webrtc/+/19e087fc91453b761b6b56ba8...

Powered by Google App Engine
This is Rietveld 408576698