Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2927763003: Revert of Replace sanitizers:deps with exe_and_shlib_deps (webrtc) (Closed)

Created:
1 year, 11 months ago by kjellander_webrtc
Modified:
1 year, 11 months ago
Reviewers:
mbonadei
CC:
webrtc-reviews_webrtc.org
Target Ref:
refs/branch-heads/59
Project:
webrtc
Visibility:
Public.

Description

Revert of Replace sanitizers:deps with exe_and_shlib_deps (webrtc) (patchset #1 id:1 of https://codereview.webrtc.org/2930603002/ ) Reason for revert: Breaks Chrome official builders (http://crbug.com/730934) Original issue's description: > Replace sanitizers:deps with exe_and_shlib_deps (webrtc) > > BUG=chromium:723069, webrtc:7762 > R=mbonadei@webrtc.org > NOTRY=True > NOPRESUBMIT=true > > Review-Url: https://codereview.webrtc.org/2897523002 > Cr-Original-Commit-Position: refs/heads/master@{#18206} > Review-Url: https://codereview.webrtc.org/2930603002 > Cr-Commit-Position: refs/branch-heads/59@{#17} > Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657} > Committed: https://chromium.googlesource.com/external/webrtc/+/0d665af77aadb2339722ffdefa257588fadc1a78 TBR=mbonadei@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:723069, webrtc:7762, chromium:730934 Review-Url: https://codereview.webrtc.org/2927763003 Cr-Commit-Position: refs/branch-heads/59@{#18} Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657} Committed: https://chromium.googlesource.com/external/webrtc/+/26d147165e71878fb183b4d16f20ccfe8b12b3c3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/tools/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/webrtc.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
kjellander_webrtc
Created Revert of Replace sanitizers:deps with exe_and_shlib_deps (webrtc)
1 year, 11 months ago (2017-06-08 05:25:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2927763003/1
1 year, 11 months ago (2017-06-08 05:27:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/26d147165e71878fb183b4d16f20ccfe8b12b3c3
1 year, 11 months ago (2017-06-08 05:27:13 UTC) #7
mbonadei
1 year, 11 months ago (2017-06-08 06:36:57 UTC) #8
Message was sent while issue was closed.
On 2017/06/08 05:27:13, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/external/webrtc/+/26d147165e71878fb183b4d16...

lgtm

Powered by Google App Engine
This is Rietveld 408576698