Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2897523002:
Replace sanitizers:deps with exe_and_shlib_deps (webrtc) (Closed)
|
Created:
3 years, 7 months ago by Tom (Use chromium acct) Modified:
3 years, 7 months ago Reviewers:
kjellander_webrtc CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionReplace sanitizers:deps with exe_and_shlib_deps (webrtc)
BUG=chromium:723069
R=kjellander@webrtc.org
Review-Url: https://codereview.webrtc.org/2897523002
Cr-Commit-Position: refs/heads/master@{#18206}
Committed: https://chromium.googlesource.com/external/webrtc/+/7f52f084219fdd8003ff0312b81a2a991ad5f572
Patch Set 1 #Patch Set 2 : / => : #Messages
Total messages: 26 (19 generated)
Patchset #2 (id:20001) has been deleted
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios32_sim_ios9_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios32_sim_ios9_dbg/buil...) ios64_sim_ios10_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_ios10_dbg/bui...) ios_dbg on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_dbg/builds/25729) ios_rel on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/24651)
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/17190)
Description was changed from ========== Replace sanitizers:deps with exe_and_shlib_deps (webrtc) Bug=chromium:723069 R=kjellander@webrtc.org ========== to ========== Replace sanitizers:deps with exe_and_shlib_deps (webrtc) BUG=chromium:723069 R=kjellander@webrtc.org ==========
The CQ bit was checked by thomasanderson@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm Thanks for doing this for us.
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/17196)
On 2017/05/19 06:32:46, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > presubmit on master.tryserver.webrtc (JOB_FAILED, > http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/17196) I'm fixing this in https://codereview.webrtc.org/2892873002, will commit after that lands.
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495176544244810,
"parent_rev": "49aaaf1053d5f12e2c990c5342e1fea7fd1138a6", "commit_rev":
"7f52f084219fdd8003ff0312b81a2a991ad5f572"}
Message was sent while issue was closed.
Description was changed from ========== Replace sanitizers:deps with exe_and_shlib_deps (webrtc) BUG=chromium:723069 R=kjellander@webrtc.org ========== to ========== Replace sanitizers:deps with exe_and_shlib_deps (webrtc) BUG=chromium:723069 R=kjellander@webrtc.org Review-Url: https://codereview.webrtc.org/2897523002 Cr-Commit-Position: refs/heads/master@{#18206} Committed: https://chromium.googlesource.com/external/webrtc/+/7f52f084219fdd8003ff0312b... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/7f52f084219fdd8003ff0312b... |
