Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(19)

Issue 2892873002: Remove CheckChangeHasTestField PRESUBMIT check. (Closed)

Created:
2 years, 4 months ago by kjellander_webrtc
Modified:
2 years, 4 months ago
Reviewers:
ehmaldonado_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove CheckChangeHasTestField PRESUBMIT check. Depot tools removed it in https://chromium-review.googlesource.com/c/506450/ so we don't have a choice. We never enforced it or had it connected to any organized follow-up anyway, so it makes sense to remove it. BUG=None TBR=ehmaldonado@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2892873002 Cr-Commit-Position: refs/heads/master@{#18205} Committed: https://chromium.googlesource.com/external/webrtc/+/49aaaf1053d5f12e2c990c5342e1fea7fd1138a6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M PRESUBMIT.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2892873002/1
2 years, 4 months ago (2017-05-19 06:43:25 UTC) #3
commit-bot: I haz the power
2 years, 4 months ago (2017-05-19 06:46:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/49aaaf1053d5f12e2c990c534...

Powered by Google App Engine
This is Rietveld 408576698