Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: PRESUBMIT.py

Issue 2892873002: Remove CheckChangeHasTestField PRESUBMIT check. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import json 9 import json
10 import os 10 import os
(...skipping 580 matching lines...) Expand 10 before | Expand all | Expand 10 after
591 def CheckChangeOnCommit(input_api, output_api): 591 def CheckChangeOnCommit(input_api, output_api):
592 results = [] 592 results = []
593 results.extend(_CommonChecks(input_api, output_api)) 593 results.extend(_CommonChecks(input_api, output_api))
594 results.extend(_VerifyNativeApiHeadersListIsValid(input_api, output_api)) 594 results.extend(_VerifyNativeApiHeadersListIsValid(input_api, output_api))
595 results.extend(input_api.canned_checks.CheckOwners(input_api, output_api)) 595 results.extend(input_api.canned_checks.CheckOwners(input_api, output_api))
596 results.extend(input_api.canned_checks.CheckChangeWasUploaded( 596 results.extend(input_api.canned_checks.CheckChangeWasUploaded(
597 input_api, output_api)) 597 input_api, output_api))
598 results.extend(input_api.canned_checks.CheckChangeHasDescription( 598 results.extend(input_api.canned_checks.CheckChangeHasDescription(
599 input_api, output_api)) 599 input_api, output_api))
600 results.extend(_CheckChangeHasBugField(input_api, output_api)) 600 results.extend(_CheckChangeHasBugField(input_api, output_api))
601 results.extend(input_api.canned_checks.CheckChangeHasTestField(
602 input_api, output_api))
603 results.extend(input_api.canned_checks.CheckTreeIsOpen( 601 results.extend(input_api.canned_checks.CheckTreeIsOpen(
604 input_api, output_api, 602 input_api, output_api,
605 json_url='http://webrtc-status.appspot.com/current?format=json')) 603 json_url='http://webrtc-status.appspot.com/current?format=json'))
606 return results 604 return results
607 605
608 606
609 def _CheckOrphanHeaders(input_api, output_api): 607 def _CheckOrphanHeaders(input_api, output_api):
610 # We need to wait until we have an input_api object and use this 608 # We need to wait until we have an input_api object and use this
611 # roundabout construct to import prebubmit_checks_lib because this file is 609 # roundabout construct to import prebubmit_checks_lib because this file is
612 # eval-ed and thus doesn't have __file__. 610 # eval-ed and thus doesn't have __file__.
(...skipping 14 matching lines...) Expand all
627 if f.LocalPath().endswith('.h') and f.Action() == 'A': 625 if f.LocalPath().endswith('.h') and f.Action() == 'A':
628 file_path = os.path.abspath(f.LocalPath()) 626 file_path = os.path.abspath(f.LocalPath())
629 root_dir = os.getcwd() 627 root_dir = os.getcwd()
630 gn_file_path = GetBuildGnPathFromFilePath(file_path, os.path.exists, 628 gn_file_path = GetBuildGnPathFromFilePath(file_path, os.path.exists,
631 root_dir) 629 root_dir)
632 in_build_gn = IsHeaderInBuildGn(file_path, gn_file_path) 630 in_build_gn = IsHeaderInBuildGn(file_path, gn_file_path)
633 if not in_build_gn: 631 if not in_build_gn:
634 results.append(output_api.PresubmitError(error_msg.format( 632 results.append(output_api.PresubmitError(error_msg.format(
635 file_path, gn_file_path))) 633 file_path, gn_file_path)))
636 return results 634 return results
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698