Chromium Code Reviews
|
|
|
Created:
1 year, 9 months ago by kjellander_webrtc Modified:
1 year, 9 months ago Reviewers:
mbonadei CC:
webrtc-reviews_webrtc.org Target Ref:
refs/branch-heads/59 Project:
webrtc Visibility:
Public. |
DescriptionReplace sanitizers:deps with exe_and_shlib_deps (webrtc)
BUG=chromium:723069, webrtc:7762
R=mbonadei@webrtc.org
NOTRY=True
NOPRESUBMIT=true
Review-Url: https://codereview.webrtc.org/2897523002
Cr-Original-Commit-Position: refs/heads/master@{#18206}
Review-Url: https://codereview.webrtc.org/2930603002
Cr-Commit-Position: refs/branch-heads/59@{#17}
Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657}
Committed: https://chromium.googlesource.com/external/webrtc/+/0d665af77aadb2339722ffdefa257588fadc1a78
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
Description was changed from ========== Replace sanitizers:deps with exe_and_shlib_deps (webrtc) BUG=chromium:723069 R=kjellander@webrtc.org Review-Url: https://codereview.webrtc.org/2897523002 Cr-Commit-Position: refs/heads/master@{#18206} (cherry picked from commit 7f52f084219fdd8003ff0312b81a2a991ad5f572) ========== to ========== Replace sanitizers:deps with exe_and_shlib_deps (webrtc) BUG=chromium:723069 R=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2897523002 Cr-Commit-Position: refs/heads/master@{#18206} (cherry picked from commit 7f52f084219fdd8003ff0312b81a2a991ad5f572) ==========
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-webrtc-committers". Note that this has nothing to do with OWNERS files.
kjellander@webrtc.org changed reviewers: + mbonadei@webrtc.org - kjellander@webrtc.org
Mirko, can you rubberstamp this (merge to 59 branch to fix GN error)
Description was changed from ========== Replace sanitizers:deps with exe_and_shlib_deps (webrtc) BUG=chromium:723069 R=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2897523002 Cr-Commit-Position: refs/heads/master@{#18206} (cherry picked from commit 7f52f084219fdd8003ff0312b81a2a991ad5f572) ========== to ========== Replace sanitizers:deps with exe_and_shlib_deps (webrtc) BUG=chromium:723069, webrtc:7762 R=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2897523002 Cr-Commit-Position: refs/heads/master@{#18206} (cherry picked from commit 7f52f084219fdd8003ff0312b81a2a991ad5f572) ==========
Description was changed from ========== Replace sanitizers:deps with exe_and_shlib_deps (webrtc) BUG=chromium:723069, webrtc:7762 R=kjellander@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2897523002 Cr-Commit-Position: refs/heads/master@{#18206} (cherry picked from commit 7f52f084219fdd8003ff0312b81a2a991ad5f572) ========== to ========== Replace sanitizers:deps with exe_and_shlib_deps (webrtc) BUG=chromium:723069, webrtc:7762 R=mbonadei@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2897523002 Cr-Commit-Position: refs/heads/master@{#18206} (cherry picked from commit 7f52f084219fdd8003ff0312b81a2a991ad5f572) ==========
Description was changed from ========== Replace sanitizers:deps with exe_and_shlib_deps (webrtc) BUG=chromium:723069, webrtc:7762 R=mbonadei@webrtc.org NOTRY=True Review-Url: https://codereview.webrtc.org/2897523002 Cr-Commit-Position: refs/heads/master@{#18206} (cherry picked from commit 7f52f084219fdd8003ff0312b81a2a991ad5f572) ========== to ========== Replace sanitizers:deps with exe_and_shlib_deps (webrtc) BUG=chromium:723069, webrtc:7762 R=mbonadei@webrtc.org NOTRY=True NOPRESUBMIT=true Review-Url: https://codereview.webrtc.org/2897523002 Cr-Commit-Position: refs/heads/master@{#18206} (cherry picked from commit 7f52f084219fdd8003ff0312b81a2a991ad5f572) ==========
On 2017/06/07 06:18:35, kjellander_webrtc wrote: > Mirko, can you rubberstamp this (merge to 59 branch to fix GN error) lgtm.
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1496820498541750, "parent_rev":
"38ffd9a17b16c18eb00e2f86f077d64bc14388b9", "commit_rev":
"0d665af77aadb2339722ffdefa257588fadc1a78"}
Message was sent while issue was closed.
Description was changed from ========== Replace sanitizers:deps with exe_and_shlib_deps (webrtc) BUG=chromium:723069, webrtc:7762 R=mbonadei@webrtc.org NOTRY=True NOPRESUBMIT=true Review-Url: https://codereview.webrtc.org/2897523002 Cr-Commit-Position: refs/heads/master@{#18206} (cherry picked from commit 7f52f084219fdd8003ff0312b81a2a991ad5f572) ========== to ========== Replace sanitizers:deps with exe_and_shlib_deps (webrtc) BUG=chromium:723069, webrtc:7762 R=mbonadei@webrtc.org NOTRY=True NOPRESUBMIT=true Review-Url: https://codereview.webrtc.org/2897523002 Cr-Original-Commit-Position: refs/heads/master@{#18206} Review-Url: https://codereview.webrtc.org/2930603002 Cr-Commit-Position: refs/branch-heads/59@{#17} Cr-Branched-From: 10d095d4f743bc16f8e486e156c48a6d023b32c5-refs/heads/master@{#17657} Committed: https://chromium.googlesource.com/external/webrtc/+/0d665af77aadb2339722ffdef... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/0d665af77aadb2339722ffdef...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.webrtc.org/2927763003/ by kjellander@webrtc.org. The reason for reverting is: Breaks Chrome official builders (http://crbug.com/730934). |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
