Reland of Protect new header extension by field trial experiment to allow hardcoding it in SDP

Reland of Protect new header extension by field trial experiment to allow hardcoding it in SDP (patchset #1 id:1 of https://codereview.webrtc.org/2922723002/ )

Reland is done after fixes in downstream projects.

TBR=sprang@webrtc.org,asapersson@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chrome:718738
Review-Url: https://codereview.webrtc.org/2922953002
Cr-Commit-Position: refs/heads/master@{#18498}
Committed: https://chromium.googlesource.com/external/webrtc/+/cf705c5f1377a7bcb89234f84633abd6804cca90

[ilnik, 2017-06-05 08:25:38]

Created Reland of Protect new header extension by field trial experiment to
allow hardcoding it in SDP

[ilnik, 2017-06-05 08:26:28]

Description was changed from

==========
Reland of Protect new header extension by field trial experiment to allow
hardcoding it in SDP (patchset #1 id:1 of
https://codereview.webrtc.org/2922723002/ )

Reason for revert:
Fixes in downstream projects are done.

Original issue's description:
> Revert of Protect new header extension by field trial experiment to allow
hardcoding it in SDP (patchset #3 id:40001 of
https://codereview.webrtc.org/2922683002/ )
> 
> Reason for revert:
> Breaks tests in downstream projects.
> 
> Original issue's description:
> > Protect new header extension by field trial experiment to allow hardcoding
it in SDP
> > 
> > BUG=chrome:718738
> > 
> > Review-Url: https://codereview.webrtc.org/2922683002
> > Cr-Commit-Position: refs/heads/master@{#18409}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/cafa1d6bbef79d9a8507c6e78...
> 
> TBR=sprang@webrtc.org,asapersson@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=chrome:718738
> 
> Review-Url: https://codereview.webrtc.org/2922723002
> Cr-Commit-Position: refs/heads/master@{#18414}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/ed9b9ff5973579cb8cb25aa4c...

TBR=sprang@webrtc.org,asapersson@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chrome:718738
==========

to

==========
Reland of Protect new header extension by field trial experiment to allow
hardcoding it in SDP (patchset #1 id:1 of
https://codereview.webrtc.org/2922723002/ )

Reland is done after fixes in downstream projects.

TBR=sprang@webrtc.org,asapersson@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chrome:718738
==========

[danilchap, 2017-06-07 08:55:11]

danilchap@webrtc.org changed reviewers:
+ danilchap@webrtc.org

[danilchap, 2017-06-07 08:55:12]

https://codereview.webrtc.org/2922953002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc (right):

https://codereview.webrtc.org/2922953002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc:332:
webrtc::field_trial::IsEnabled("WebRTC-VideoContentTypeExtension")) {
May be instead check for the experiment in
webrtc::VideoSendStreamImpl::VideoSendStreamImpl:
 skip call to rtp_rtcp->RegisterSendRtpHeaderExtension if the extension is video
content type and not in the experiment.

[ilnik, 2017-06-07 15:22:11]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-07 15:22:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[ilnik, 2017-06-07 15:23:14]

https://codereview.webrtc.org/2922953002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc (right):

https://codereview.webrtc.org/2922953002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc:332:
webrtc::field_trial::IsEnabled("WebRTC-VideoContentTypeExtension")) {
On 2017/06/07 08:55:11, danilchap wrote:
> May be instead check for the experiment in
> webrtc::VideoSendStreamImpl::VideoSendStreamImpl:
>  skip call to rtp_rtcp->RegisterSendRtpHeaderExtension if the extension is
video
> content type and not in the experiment.

Done.

[commit-bot: I haz the power, 2017-06-07 16:15:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-07 16:15:34]

Dry run: This issue passed the CQ dry run.

[sprang_webrtc, 2017-06-08 13:16:13]

lgtm

[ilnik, 2017-06-08 13:16:54]

The CQ bit was checked by ilnik@webrtc.org

[commit-bot: I haz the power, 2017-06-08 13:17:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-08 13:18:54]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1496927814635210,
"parent_rev": "cdafeda1cb95ac49104b2cc5112bab8def863818", "commit_rev":
"cf705c5f1377a7bcb89234f84633abd6804cca90"}

[commit-bot: I haz the power, 2017-06-08 13:18:58]

Description was changed from

==========
Reland of Protect new header extension by field trial experiment to allow
hardcoding it in SDP (patchset #1 id:1 of
https://codereview.webrtc.org/2922723002/ )

Reland is done after fixes in downstream projects.

TBR=sprang@webrtc.org,asapersson@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chrome:718738
==========

to

==========
Reland of Protect new header extension by field trial experiment to allow
hardcoding it in SDP (patchset #1 id:1 of
https://codereview.webrtc.org/2922723002/ )

Reland is done after fixes in downstream projects.

TBR=sprang@webrtc.org,asapersson@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=chrome:718738

Review-Url: https://codereview.webrtc.org/2922953002
Cr-Commit-Position: refs/heads/master@{#18498}
Committed:
https://chromium.googlesource.com/external/webrtc/+/cf705c5f1377a7bcb89234f84...
==========

[commit-bot: I haz the power, 2017-06-08 13:18:59]

Committed patchset #2 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/cf705c5f1377a7bcb89234f84...