Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2922683002: Protect new header extension by field trial experiment to allow hardcoding it in SDP (Closed)

Created:
3 years, 6 months ago by ilnik
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Protect new header extension by field trial experiment to allow hardcoding it in SDP BUG=chrome:718738 Review-Url: https://codereview.webrtc.org/2922683002 Cr-Commit-Position: refs/heads/master@{#18409} Committed: https://chromium.googlesource.com/external/webrtc/+/cafa1d6bbef79d9a8507c6e782f3c7824ef1070b

Patch Set 1 #

Patch Set 2 : Force field trial in tests #

Patch Set 3 : Fix typos and add missing field trial forcing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (22 generated)
ilnik
3 years, 6 months ago (2017-06-02 10:39:02 UTC) #2
sprang_webrtc
lgtm
3 years, 6 months ago (2017-06-02 10:42:38 UTC) #7
ilnik
+assapersson, Asa, your approval is needed for modules/rtp_rtcp.
3 years, 6 months ago (2017-06-02 11:11:26 UTC) #13
åsapersson
lgtm
3 years, 6 months ago (2017-06-02 11:48:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2922683002/40001
3 years, 6 months ago (2017-06-02 12:47:24 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/cafa1d6bbef79d9a8507c6e782f3c7824ef1070b
3 years, 6 months ago (2017-06-02 12:49:44 UTC) #26
ilnik
3 years, 6 months ago (2017-06-02 14:29:51 UTC) #27
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/2922723002/ by ilnik@webrtc.org.

The reason for reverting is: Breaks tests in downstream projects..

Powered by Google App Engine
This is Rietveld 408576698