|
|
Chromium Code Reviews
DescriptionProtect new header extension by field trial experiment to allow hardcoding it in SDP
BUG=chrome:718738
Review-Url: https://codereview.webrtc.org/2922683002
Cr-Commit-Position: refs/heads/master@{#18409}
Committed: https://chromium.googlesource.com/external/webrtc/+/cafa1d6bbef79d9a8507c6e782f3c7824ef1070b
Patch Set 1 #Patch Set 2 : Force field trial in tests #Patch Set 3 : Fix typos and add missing field trial forcing #
Messages
Total messages: 29 (22 generated)
ilnik@webrtc.org changed reviewers: + sprang@webrtc.org
The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
Description was changed from ========== Protect new header extension by finch experiment to allow hardcoding it in SDP BUG=chrome:718738 ========== to ========== Protect new header extension by finch experiment to allow hardcoding it in SDP BUG=chromium:718738 ==========
Description was changed from ========== Protect new header extension by finch experiment to allow hardcoding it in SDP BUG=chromium:718738 ========== to ========== Protect new header extension by field trial experiment to allow hardcoding it in SDP BUG=chrome:718738 ==========
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/25137)
The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
ilnik@webrtc.org changed reviewers: + asapersson@webrtc.org
+assapersson, Asa, your approval is needed for modules/rtp_rtcp.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_asan on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_asan/builds/25216) linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds...)
The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ilnik@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from sprang@webrtc.org Link to the patchset: https://codereview.webrtc.org/2922683002/#ps40001 (title: "Fix typos and add missing field trial forcing")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496407639115140,
"parent_rev": "58c742ce7dbf6143295245f32019deadf03ffd87", "commit_rev":
"cafa1d6bbef79d9a8507c6e782f3c7824ef1070b"}
Message was sent while issue was closed.
Description was changed from ========== Protect new header extension by field trial experiment to allow hardcoding it in SDP BUG=chrome:718738 ========== to ========== Protect new header extension by field trial experiment to allow hardcoding it in SDP BUG=chrome:718738 Review-Url: https://codereview.webrtc.org/2922683002 Cr-Commit-Position: refs/heads/master@{#18409} Committed: https://chromium.googlesource.com/external/webrtc/+/cafa1d6bbef79d9a8507c6e78... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/cafa1d6bbef79d9a8507c6e78...
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.webrtc.org/2922723002/ by ilnik@webrtc.org. The reason for reverting is: Breaks tests in downstream projects..
Message was sent while issue was closed.
Patchset #4 (id:60001) has been deleted
Message was sent while issue was closed.
Patchset #4 (id:80001) has been deleted |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
