Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2922723002: Revert of Protect new header extension by field trial experiment to allow hardcoding it in SDP (Closed)

Created:
3 years, 6 months ago by ilnik
Modified:
3 years, 6 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Protect new header extension by field trial experiment to allow hardcoding it in SDP (patchset #3 id:40001 of https://codereview.webrtc.org/2922683002/ ) Reason for revert: Breaks tests in downstream projects. Original issue's description: > Protect new header extension by field trial experiment to allow hardcoding it in SDP > > BUG=chrome:718738 > > Review-Url: https://codereview.webrtc.org/2922683002 > Cr-Commit-Position: refs/heads/master@{#18409} > Committed: https://chromium.googlesource.com/external/webrtc/+/cafa1d6bbef79d9a8507c6e782f3c7824ef1070b TBR=sprang@webrtc.org,asapersson@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chrome:718738 Review-Url: https://codereview.webrtc.org/2922723002 Cr-Commit-Position: refs/heads/master@{#18414} Committed: https://chromium.googlesource.com/external/webrtc/+/ed9b9ff5973579cb8cb25aa4cc299b810e151ac0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_sender_video.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/video/end_to_end_tests.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ilnik
Created Revert of Protect new header extension by field trial experiment to allow hardcoding it ...
3 years, 6 months ago (2017-06-02 14:29:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2922723002/1
3 years, 6 months ago (2017-06-02 14:29:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/ed9b9ff5973579cb8cb25aa4cc299b810e151ac0
3 years, 6 months ago (2017-06-02 14:30:24 UTC) #6
ilnik
3 years, 6 months ago (2017-06-05 08:25:37 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2922953002/ by ilnik@webrtc.org.

The reason for reverting is: Fixes in downstream projects are done..

Powered by Google App Engine
This is Rietveld 408576698