Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2897943003: Fix DumpAccessibilityEvents tests on Mac and improve test coverage (Closed)

Created:
3 years, 7 months ago by dmazzoni
Modified:
3 years, 7 months ago
Reviewers:
nektarios
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dougt+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, mac-reviews_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix DumpAccessibilityEvents tests on Mac and improve test coverage Fix some minor issues that caused DumpAccessibilityEvents tests to fail or behave flakily. Re-enable several tests and add many more with a goal of covering all possible Mac notifications with tests. This is part of a larger effort to fire fewer events from Blink and fire them in platform-specific code instead. Increasing test coverage will help with this. BUG=719030, 699438 Review-Url: https://codereview.chromium.org/2897943003 Cr-Commit-Position: refs/heads/master@{#474971} Committed: https://chromium.googlesource.com/chromium/src/+/2751e50876e2591e8268c124001b58dabfab6828

Patch Set 1 #

Patch Set 2 : Rebaseline one more windows test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -91 lines) Patch
M content/browser/accessibility/accessibility_event_recorder_mac.mm View 1 chunk +10 lines, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.h View 1 2 chunks +10 lines, -4 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 1 4 chunks +8 lines, -6 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_mac.mm View 3 chunks +10 lines, -2 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_browsertest_base.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_events_browsertest.cc View 1 6 chunks +45 lines, -32 lines 0 comments Download
M content/test/data/accessibility/event/aria-combo-box-collapse.html View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/data/accessibility/event/aria-combo-box-expand.html View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/data/accessibility/event/aria-combo-box-focus.html View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/data/accessibility/event/aria-combo-box-focus-expected-win.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/event/aria-combo-box-next.html View 1 chunk +0 lines, -3 lines 0 comments Download
A content/test/data/accessibility/event/aria-tree-collapse.html View 1 chunk +29 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/aria-tree-collapse-expected-mac.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/aria-tree-expand.html View 1 chunk +29 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/aria-tree-expand-expected-mac.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/aria-treeitem-focus.html View 1 chunk +28 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/aria-treeitem-focus-expected-mac.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M content/test/data/accessibility/event/expanded-change.html View 1 chunk +0 lines, -4 lines 0 comments Download
M content/test/data/accessibility/event/input-type-text-value-changed.html View 1 chunk +2 lines, -1 line 0 comments Download
A content/test/data/accessibility/event/invalid-status-change.html View 1 chunk +11 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/invalid-status-change-expected-mac.txt View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/event/listbox-focus.html View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/data/accessibility/event/listbox-next.html View 1 chunk +0 lines, -3 lines 0 comments Download
A content/test/data/accessibility/event/live-region-add.html View 1 chunk +13 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/live-region-add-expected-mac.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/event/live-region-change.html View 1 chunk +11 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/live-region-change-expected-mac.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/event/live-region-create.html View 1 chunk +12 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/live-region-create-expected-mac.txt View 1 chunk +1 line, -0 lines 0 comments Download
A content/test/data/accessibility/event/live-region-remove.html View 1 chunk +12 lines, -0 lines 0 comments Download
A content/test/data/accessibility/event/live-region-remove-expected-mac.txt View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/data/accessibility/event/menulist-collapse.html View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/data/accessibility/event/menulist-expand.html View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/data/accessibility/event/menulist-focus.html View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/data/accessibility/event/menulist-next.html View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/data/accessibility/event/menulist-popup.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
dmazzoni
3 years, 7 months ago (2017-05-24 17:47:46 UTC) #7
nektarios
lgtm
3 years, 7 months ago (2017-05-25 17:48:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897943003/1
3 years, 7 months ago (2017-05-25 20:44:14 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/454651)
3 years, 7 months ago (2017-05-25 22:23:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897943003/20001
3 years, 7 months ago (2017-05-26 06:53:19 UTC) #15
commit-bot: I haz the power
3 years, 7 months ago (2017-05-26 09:03:29 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2751e50876e2591e8268c124001b...

Powered by Google App Engine
This is Rietveld 408576698