Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1104)

Unified Diff: content/browser/accessibility/browser_accessibility_manager_mac.mm

Issue 2897943003: Fix DumpAccessibilityEvents tests on Mac and improve test coverage (Closed)
Patch Set: Rebaseline one more windows test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_manager_mac.mm
diff --git a/content/browser/accessibility/browser_accessibility_manager_mac.mm b/content/browser/accessibility/browser_accessibility_manager_mac.mm
index 8e70dd3872c3aa59de1da0b266d8d4beb32efdb5..51f453f678c19d9f1fcff1a0292c296d98618048 100644
--- a/content/browser/accessibility/browser_accessibility_manager_mac.mm
+++ b/content/browser/accessibility/browser_accessibility_manager_mac.mm
@@ -222,8 +222,6 @@ void BrowserAccessibilityManagerMac::NotifyAccessibilityEvent(
BrowserAccessibility* focus = GetFocus();
if (!focus)
break; // Just fire a notification on the root.
- NSAccessibilityPostNotification(ToBrowserAccessibilityCocoa(focus),
- mac_notification);
if (base::mac::IsAtLeastOS10_11()) {
// |NSAccessibilityPostNotificationWithUserInfo| should be used on OS X
@@ -242,6 +240,9 @@ void BrowserAccessibilityManagerMac::NotifyAccessibilityEvent(
NSAccessibilityPostNotificationWithUserInfo(
ToBrowserAccessibilityCocoa(root), mac_notification, user_info);
return;
+ } else {
+ NSAccessibilityPostNotification(ToBrowserAccessibilityCocoa(focus),
+ mac_notification);
}
break;
}
@@ -288,6 +289,13 @@ void BrowserAccessibilityManagerMac::NotifyAccessibilityEvent(
// Voiceover seems to drop live region changed notifications if they come
// too soon after a live region created notification.
// TODO(nektar): Limit the number of changed notifications as well.
+
+ if (never_suppress_or_delay_events_for_testing_) {
+ NSAccessibilityPostNotification(
+ native_node, NSAccessibilityLiveRegionChangedNotification);
+ return;
+ }
+
base::scoped_nsobject<BrowserAccessibilityCocoa> retained_node(
[native_node retain]);
BrowserThread::PostDelayedTask(

Powered by Google App Engine
This is Rietveld 408576698