Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Unified Diff: content/browser/accessibility/browser_accessibility_manager.h

Issue 2897943003: Fix DumpAccessibilityEvents tests on Mac and improve test coverage (Closed)
Patch Set: Rebaseline one more windows test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_manager.h
diff --git a/content/browser/accessibility/browser_accessibility_manager.h b/content/browser/accessibility/browser_accessibility_manager.h
index 3f7c5ca0007a8fcf71120f0a00b6d2240a13e37b..fa0478a92ed71d42e1f920c1d7aac8c42a71ca21 100644
--- a/content/browser/accessibility/browser_accessibility_manager.h
+++ b/content/browser/accessibility/browser_accessibility_manager.h
@@ -184,10 +184,12 @@ class CONTENT_EXPORT BrowserAccessibilityManager : public ui::AXTreeDelegate {
static void SetFocusChangeCallbackForTesting(const base::Closure& callback);
// Normally we avoid firing accessibility focus events when the containing
- // native window isn't focused. However, this can lead to test flakiness
- // because we can't control when a window loses focus, so this provides a
- // way to disable that check for tests.
- static void NeverSuppressFocusEventsForTesting();
+ // native window isn't focused, and we also delay some other events like
+ // live region events to improve screen reader compatibility.
+ // However, this can lead to test flakiness, so for testing, simplify
+ // this behavior and just fire all events with no delay as if the window
+ // had focus.
+ static void NeverSuppressOrDelayEventsForTesting();
// Accessibility actions. All of these are implemented asynchronously
// by sending a message to the renderer to perform the respective action
@@ -492,6 +494,10 @@ class CONTENT_EXPORT BrowserAccessibilityManager : public ui::AXTreeDelegate {
// used and it won't be updated from the delegate.
bool use_custom_device_scale_factor_for_testing_;
+ // Fire all events regardless of focus and with no delay, to avoid test
+ // flakiness. See NeverSuppressOrDelayEventsForTesting() for details.
+ static bool never_suppress_or_delay_events_for_testing_;
+
private:
DISALLOW_COPY_AND_ASSIGN(BrowserAccessibilityManager);
};

Powered by Google App Engine
This is Rietveld 408576698