Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 2870393006: Moving check_package_boundaries to the presubmit checks directory (Closed)

Created:
3 years, 7 months ago by mbonadei
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Moving check_package_boundaries to the presubmit checks directory Since we now have a directory for this kind of checks, let's move this to that location. BUG=None NOTRY=True Review-Url: https://codereview.webrtc.org/2870393006 Cr-Commit-Position: refs/heads/master@{#18122} Committed: https://chromium.googlesource.com/external/webrtc/+/ab587dc9a4b67c8d64be7e11c99fffdf51f0a1f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-23 lines, -372 lines) Patch
M PRESUBMIT.py View 1 chunk +2 lines, -1 line 0 comments Download
D tools_webrtc/check_package_boundaries.py View 1 chunk +0 lines, -137 lines 0 comments Download
D tools_webrtc/check_package_boundaries_test.py View 1 chunk +0 lines, -68 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/check_package_boundaries.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/check_package_boundaries_test.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/all_build_files/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/all_build_files/expected.pyl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/all_build_files/subpackage1/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/all_build_files/subpackage1/subsubpackage1/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/all_build_files/subpackage2/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/all_build_files/subpackage2/subsubpackage2/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/common_prefix/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/common_prefix/call/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/common_prefix/expected.pyl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_multiple_targets/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_multiple_targets/expected.pyl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_multiple_targets/subpackage1/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_multiple_targets/subpackage2/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_single_target/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_single_target/expected.pyl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/multiple_errors_single_target/subpackage/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/no_errors/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tools_webrtc/presubmit_checks_lib/testdata/no_errors/expected.pyl View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools_webrtc/testdata/all_build_files/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D tools_webrtc/testdata/all_build_files/expected.pyl View 1 chunk +0 lines, -20 lines 0 comments Download
D tools_webrtc/testdata/all_build_files/subpackage1/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
D tools_webrtc/testdata/all_build_files/subpackage1/subsubpackage1/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools_webrtc/testdata/all_build_files/subpackage2/BUILD.gn View 1 chunk +0 lines, -15 lines 0 comments Download
D tools_webrtc/testdata/all_build_files/subpackage2/subsubpackage2/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools_webrtc/testdata/common_prefix/BUILD.gn View 1 chunk +0 lines, -17 lines 0 comments Download
D tools_webrtc/testdata/common_prefix/call/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools_webrtc/testdata/common_prefix/expected.pyl View 1 chunk +0 lines, -1 line 0 comments Download
D tools_webrtc/testdata/multiple_errors_multiple_targets/BUILD.gn View 1 chunk +0 lines, -28 lines 0 comments Download
D tools_webrtc/testdata/multiple_errors_multiple_targets/expected.pyl View 1 chunk +0 lines, -20 lines 0 comments Download
D tools_webrtc/testdata/multiple_errors_multiple_targets/subpackage1/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools_webrtc/testdata/multiple_errors_multiple_targets/subpackage2/BUILD.gn View 0 chunks +-1 lines, --1 lines 0 comments Download
D tools_webrtc/testdata/multiple_errors_single_target/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D tools_webrtc/testdata/multiple_errors_single_target/expected.pyl View 1 chunk +0 lines, -10 lines 0 comments Download
D tools_webrtc/testdata/multiple_errors_single_target/subpackage/BUILD.gn View 1 chunk +0 lines, -14 lines 0 comments Download
D tools_webrtc/testdata/no_errors/BUILD.gn View 1 chunk +0 lines, -22 lines 0 comments Download
D tools_webrtc/testdata/no_errors/expected.pyl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
mbonadei
3 years, 7 months ago (2017-05-12 06:03:47 UTC) #3
kjellander_webrtc
lgtm Thanks for the cleanup!
3 years, 7 months ago (2017-05-12 06:24:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2870393006/1
3 years, 7 months ago (2017-05-12 11:10:32 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 11:13:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/ab587dc9a4b67c8d64be7e11c...

Powered by Google App Engine
This is Rietveld 408576698