Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: tools_webrtc/check_package_boundaries_test.py

Issue 2870393006: Moving check_package_boundaries to the presubmit checks directory (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 #!/usr/bin/env python
2
3 # Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
4 #
5 # Use of this source code is governed by a BSD-style license
6 # that can be found in the LICENSE file in the root of the source
7 # tree. An additional intellectual property rights grant can be found
8 # in the file PATENTS. All contributing project authors may
9 # be found in the AUTHORS file in the root of the source tree.
10
11 import ast
12 import os
13 import unittest
14
15 from check_package_boundaries import CheckPackageBoundaries
16
17
18 MSG_FORMAT = 'ERROR:check_package_boundaries.py: Unexpected %s.'
19 TESTDATA_DIR = os.path.join(os.path.dirname(os.path.abspath(__file__)),
20 'testdata')
21
22
23 def ReadPylFile(file_path):
24 with open(file_path) as f:
25 return ast.literal_eval(f.read())
26
27
28 class Logger(object):
29 def __init__(self, test_dir):
30 self.messages = []
31 self.test_dir = test_dir
32
33 def Log(self, build_file_path, line_number, target_name, source_file,
34 subpackage):
35 build_file_path = os.path.relpath(build_file_path, self.test_dir)
36 build_file_path = build_file_path.replace(os.path.sep, '/')
37 self.messages.append([build_file_path, line_number, target_name,
38 source_file, subpackage])
39
40
41 class UnitTest(unittest.TestCase):
42 def RunTest(self, test_dir, check_all_build_files=False):
43 logger = Logger(test_dir)
44 build_files = [os.path.join(test_dir, 'BUILD.gn')]
45 if check_all_build_files:
46 build_files = None
47 CheckPackageBoundaries(test_dir, logger, build_files)
48 expected_messages = ReadPylFile(os.path.join(test_dir, 'expected.pyl'))
49 self.assertListEqual(sorted(expected_messages), sorted(logger.messages))
50
51 def testNoErrors(self):
52 self.RunTest(os.path.join(TESTDATA_DIR, 'no_errors'))
53
54 def testMultipleErrorsSingleTarget(self):
55 self.RunTest(os.path.join(TESTDATA_DIR, 'multiple_errors_single_target'))
56
57 def testMultipleErrorsMultipleTargets(self):
58 self.RunTest(os.path.join(TESTDATA_DIR, 'multiple_errors_multiple_targets'))
59
60 def testCommonPrefix(self):
61 self.RunTest(os.path.join(TESTDATA_DIR, 'common_prefix'))
62
63 def testAllBuildFiles(self):
64 self.RunTest(os.path.join(TESTDATA_DIR, 'all_build_files'), True)
65
66
67 if __name__ == '__main__':
68 unittest.main()
OLDNEW
« no previous file with comments | « tools_webrtc/check_package_boundaries.py ('k') | tools_webrtc/presubmit_checks_lib/check_package_boundaries.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698