Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(883)

Issue 2867703002: Reland of Delete deprecated and transitional stuff related to video frame refactoring. (Closed)

Created:
3 years, 7 months ago by nisse-webrtc
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, noahric-google, mbonadei
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Delete deprecated and transitional stuff related to video frame refactoring. (patchset #1 id:1 of https://codereview.webrtc.org/2853383005/ ) Reason for revert: Downstream projects have been fixed. Original issue's description: > Revert of Delete deprecated and transitional stuff related to video frame refactoring. (patchset #1 id:1 of https://codereview.webrtc.org/2854873003/ ) > > Reason for revert: > More downstream breakage discovered. > > Original issue's description: > > Reland of Delete deprecated and transitional stuff related to video frame refactoring. (patchset #1 id:1 of https://codereview.webrtc.org/2854883002/ ) > > > > Reason for revert: > > Will make another attempt to track down and fix downstream projects. > > > > Original issue's description: > > > Revert of Delete deprecated and transitional stuff related to video frame refactoring. (patchset #1 id:1 of https://codereview.webrtc.org/2852303002/ ) > > > > > > Reason for revert: > > > Unfortunately, more downstream updates needed. > > > > > > Original issue's description: > > > > Reland of Delete deprecated and transitional stuff related to video frame refactoring. (patchset #1 id:1 of https://codereview.webrtc.org/2845333002/ ) > > > > > > > > Reason for revert: > > > > Downstream projects being updated. > > > > > > > > For Chrome, relanding depends on cl > > > > https://codereview.chromium.org/2855783003/ > > > > > > > > Original issue's description: > > > > > Revert of Delete deprecated and transitional stuff related to video frame refactoring. (patchset #17 id:320001 of https://codereview.webrtc.org/2622263002/ ) > > > > > > > > > > Reason for revert: > > > > > Broke Chrome build, see, e.g., > > > > > http://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/16237 > > > > > > > > > > Original issue's description: > > > > > > Delete deprecated and transitional stuff related to video frame refactoring. > > > > > > > > > > > > BUG=webrtc:5880 > > > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2622263002 > > > > > > Cr-Commit-Position: refs/heads/master@{#17928} > > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/713a3bbcc74a4c1a1f54d6dbd0bdaa715f5c1ae1 > > > > > > > > > > TBR=mflodman@webrtc.org,perkj@webrtc.org > > > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > > > NOPRESUBMIT=true > > > > > NOTREECHECKS=true > > > > > NOTRY=true > > > > > BUG=webrtc:5880 > > > > > > > > > > Review-Url: https://codereview.webrtc.org/2845333002 > > > > > Cr-Commit-Position: refs/heads/master@{#17929} > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/aec49d2b49e1beceb286cbb29ad220aefd0ac648 > > > > > > > > TBR=mflodman@webrtc.org,perkj@webrtc.org > > > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > > > BUG=webrtc:5880 > > > > > > > > Review-Url: https://codereview.webrtc.org/2852303002 > > > > Cr-Commit-Position: refs/heads/master@{#17974} > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d71ebd70f6c40a37559a7ee2930002a804ad3f13 > > > > > > TBR=mflodman@webrtc.org,perkj@webrtc.org > > > # Skipping CQ checks because original CL landed less than 1 days ago. > > > NOPRESUBMIT=true > > > NOTREECHECKS=true > > > NOTRY=true > > > BUG=webrtc:5880 > > > > > > Review-Url: https://codereview.webrtc.org/2854883002 > > > Cr-Commit-Position: refs/heads/master@{#17978} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/6e6a485a028799501ea4753ceefc811dd826f52f > > > > TBR=mflodman@webrtc.org,perkj@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > > > BUG=webrtc:5880 > > > > Review-Url: https://codereview.webrtc.org/2854873003 > > Cr-Commit-Position: refs/heads/master@{#18006} > > Committed: https://chromium.googlesource.com/external/webrtc/+/3870a071c452dc2e782196bc5bba0375d019b653 > > TBR=mflodman@webrtc.org,perkj@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5880 > > Review-Url: https://codereview.webrtc.org/2853383005 > Cr-Commit-Position: refs/heads/master@{#18008} > Committed: https://chromium.googlesource.com/external/webrtc/+/61b22dde133aff91a0db6a628d87b2ea9134fa15 TBR=mflodman@webrtc.org,perkj@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:5880 Review-Url: https://codereview.webrtc.org/2867703002 Cr-Commit-Position: refs/heads/master@{#18081} Committed: https://chromium.googlesource.com/external/webrtc/+/f93752a2ee559ce385ff1ec7486876ccffa11757

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -151 lines) Patch
M webrtc/api/mediastreaminterface.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/api/video/i420_buffer.h View 1 2 chunks +0 lines, -11 lines 0 comments Download
M webrtc/api/video/i420_buffer.cc View 1 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/api/video/video_frame.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/api/video_codecs/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/video_codecs/video_decoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/video_codecs/video_encoder.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_video/i420_video_frame_unittest.cc View 1 2 chunks +1 line, -16 lines 0 comments Download
M webrtc/common_video/include/video_frame_buffer.h View 1 chunk +0 lines, -3 lines 0 comments Download
D webrtc/common_video/rotation.h View 1 chunk +0 lines, -18 lines 0 comments Download
M webrtc/media/BUILD.gn View 1 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/media/base/videocapturer.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
D webrtc/media/base/videoframe.h View 1 chunk +0 lines, -37 lines 0 comments Download
D webrtc/media/engine/webrtcvideoframe.h View 1 chunk +0 lines, -33 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/video_codec_test.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/native_handle_impl.cc View 1 2 chunks +6 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/corevideo_frame_buffer.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/objcvideotracksource.mm View 1 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/test/fake_texture_frame.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/frame_generator_capturer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/overuse_frame_detector.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video_frame.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
nisse-webrtc
Created Reland of Delete deprecated and transitional stuff related to video frame refactoring.
3 years, 7 months ago (2017-05-08 07:39:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2867703002/300001
3 years, 7 months ago (2017-05-10 06:45:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16897)
3 years, 7 months ago (2017-05-10 06:51:01 UTC) #9
nisse-webrtc
On 2017/05/10 06:51:01, commit-bot: I haz the power wrote: > Try jobs failed on following ...
3 years, 7 months ago (2017-05-10 07:21:21 UTC) #10
nisse-webrtc
kjellander: The presubmit failure is likely related to https://codereview.webrtc.org/2872493002, even though webrtc/video_frame.h is not a ...
3 years, 7 months ago (2017-05-10 11:07:11 UTC) #12
mbonadei
On 2017/05/10 11:07:11, nisse-webrtc wrote: > kjellander: The presubmit failure is likely related to > ...
3 years, 7 months ago (2017-05-10 12:00:24 UTC) #13
mbonadei
On 2017/05/10 12:00:24, mbonadei wrote: > On 2017/05/10 11:07:11, nisse-webrtc wrote: > > kjellander: The ...
3 years, 7 months ago (2017-05-10 12:09:29 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2867703002/300001
3 years, 7 months ago (2017-05-10 12:23:24 UTC) #16
mbonadei
On 2017/05/10 12:09:29, mbonadei wrote: > On 2017/05/10 12:00:24, mbonadei wrote: > > On 2017/05/10 ...
3 years, 7 months ago (2017-05-10 12:24:57 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:300001) as https://chromium.googlesource.com/external/webrtc/+/f93752a2ee559ce385ff1ec7486876ccffa11757
3 years, 7 months ago (2017-05-10 12:26:04 UTC) #21
nisse-webrtc
3 years, 7 months ago (2017-05-10 12:29:17 UTC) #22
Message was sent while issue was closed.
On 2017/05/10 12:24:57, mbonadei wrote:
> On 2017/05/10 12:09:29, mbonadei wrote:
> > On 2017/05/10 12:00:24, mbonadei wrote:
> > > On 2017/05/10 11:07:11, nisse-webrtc wrote:
> > > > kjellander: The presubmit failure is likely related to
> > > > https://codereview.webrtc.org/2872493002, even though
webrtc/video_frame.h
> > is
> > > > not a new file.
> > > 
> > > Yes, it is related to the new presubmit check. The presubmit check will
> check
> > > all the affected files and webrtc/video_frame.h is affected.
> > > I created https://bugs.chromium.org/p/webrtc/issues/detail?id=7616 but we
> have
> > > 86 orphan headers around so maybe it make sense to only run the check on
> > > newly added files?
> > 
> > Update: I am looking at how to make the check less strict.
> 
> nisse@: I have just landed https://codereview.webrtc.org/2873223004/ and it
> should
> unblock you.

Landed now, I really hope it sticks this time...

Powered by Google App Engine
This is Rietveld 408576698