Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2845333002: Revert of Delete deprecated and transitional stuff related to video frame refactoring. (Closed)

Created:
3 years, 7 months ago by nisse-webrtc
Modified:
3 years, 7 months ago
Reviewers:
perkj_webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, noahric-google
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete deprecated and transitional stuff related to video frame refactoring. (patchset #17 id:320001 of https://codereview.webrtc.org/2622263002/ ) Reason for revert: Broke Chrome build, see, e.g., http://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/builds/16237 Original issue's description: > Delete deprecated and transitional stuff related to video frame refactoring. > > BUG=webrtc:5880 > > Review-Url: https://codereview.webrtc.org/2622263002 > Cr-Commit-Position: refs/heads/master@{#17928} > Committed: https://chromium.googlesource.com/external/webrtc/+/713a3bbcc74a4c1a1f54d6dbd0bdaa715f5c1ae1 TBR=mflodman@webrtc.org,perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5880 Review-Url: https://codereview.webrtc.org/2845333002 Cr-Commit-Position: refs/heads/master@{#17929} Committed: https://chromium.googlesource.com/external/webrtc/+/aec49d2b49e1beceb286cbb29ad220aefd0ac648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -21 lines) Patch
M webrtc/api/mediastreaminterface.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/api/video/i420_buffer.h View 2 chunks +11 lines, -0 lines 0 comments Download
M webrtc/api/video/i420_buffer.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M webrtc/api/video/video_frame.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/api/video_codecs/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/video_codecs/video_decoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/api/video_codecs/video_encoder.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_video/corevideo_frame_buffer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_video/i420_video_frame_unittest.cc View 2 chunks +16 lines, -1 line 0 comments Download
M webrtc/common_video/include/video_frame_buffer.h View 1 chunk +3 lines, -0 lines 0 comments Download
A webrtc/common_video/rotation.h View 1 chunk +18 lines, -0 lines 0 comments Download
M webrtc/media/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/media/base/videocapturer.h View 1 chunk +6 lines, -0 lines 0 comments Download
A webrtc/media/base/videoframe.h View 1 chunk +37 lines, -0 lines 0 comments Download
A webrtc/media/engine/webrtcvideoframe.h View 1 chunk +33 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/video_codec_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/generic_decoder.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/sdk/android/src/jni/native_handle_impl.cc View 2 chunks +1 line, -6 lines 0 comments Download
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/objcvideotracksource.mm View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/test/fake_texture_frame.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/frame_generator_capturer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/overuse_frame_detector.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video_frame.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nisse-webrtc
Created Revert of Delete deprecated and transitional stuff related to video frame refactoring.
3 years, 7 months ago (2017-04-28 13:03:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2845333002/1
3 years, 7 months ago (2017-04-28 13:03:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/aec49d2b49e1beceb286cbb29ad220aefd0ac648
3 years, 7 months ago (2017-04-28 13:03:45 UTC) #6
nisse-webrtc
3 years, 7 months ago (2017-05-02 11:35:58 UTC) #7
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2852303002/ by nisse@webrtc.org.

The reason for reverting is: Downstream projects being updated.

For Chrome, relanding depends on cl 
https://codereview.chromium.org/2855783003/.

Powered by Google App Engine
This is Rietveld 408576698