Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2622263002: Delete deprecated and transitional stuff related to video frame refactoring. (Closed)

Created:
3 years, 11 months ago by nisse-webrtc
Modified:
3 years, 7 months ago
Reviewers:
perkj_webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, yujie_mao (webrtc), tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, the sun, noahric-google
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Delete deprecated and transitional stuff related to video frame refactoring. BUG=webrtc:5880 Review-Url: https://codereview.webrtc.org/2622263002 Cr-Commit-Position: refs/heads/master@{#17928} Committed: https://chromium.googlesource.com/external/webrtc/+/713a3bbcc74a4c1a1f54d6dbd0bdaa715f5c1ae1

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Delete deprecated and transitional stuff related to video frame refactoring. #

Patch Set 4 : Add missing includes, and rebase. #

Patch Set 5 : Include fix for objc. #

Patch Set 6 : Fixes for android and objc. #

Patch Set 7 : Drop deleted files from rtc_media and rtc_media_base targets. #

Patch Set 8 : Rebase (not compiling). #

Patch Set 9 : Add missing include. #

Patch Set 10 : Rebased (and no longer compiles). #

Patch Set 11 : Added missing include of timeutils.h. #

Patch Set 12 : Rebased. #

Patch Set 13 : Fix includes for ObjcVideoTrackSource. #

Patch Set 14 : Formatting fix. #

Patch Set 15 : Update call to I420Buffer::Rotate, to not take a smart pointer. #

Total comments: 2

Patch Set 16 : Rebased, has some gn dependency breakage. #

Patch Set 17 : Fix include order. Add dependency in api/video_codecs/BUILD.gn. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -151 lines) Patch
M webrtc/api/mediastreaminterface.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/api/video/i420_buffer.h View 2 chunks +0 lines, -11 lines 0 comments Download
M webrtc/api/video/i420_buffer.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/api/video/video_frame.h View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/api/video_codecs/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/video_codecs/video_decoder.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/api/video_codecs/video_encoder.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_video/corevideo_frame_buffer.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_video/i420_video_frame_unittest.cc View 1 2 2 chunks +1 line, -16 lines 0 comments Download
M webrtc/common_video/include/video_frame_buffer.h View 1 chunk +0 lines, -3 lines 0 comments Download
D webrtc/common_video/rotation.h View 1 chunk +0 lines, -18 lines 0 comments Download
M webrtc/media/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/media/base/videocapturer.h View 1 chunk +0 lines, -6 lines 0 comments Download
D webrtc/media/base/videoframe.h View 1 chunk +0 lines, -37 lines 0 comments Download
D webrtc/media/engine/webrtcvideoframe.h View 1 chunk +0 lines, -33 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/video_codec_test.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/video_coding/generic_decoder.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/sdk/android/src/jni/native_handle_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +6 lines, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/avfoundationvideocapturer.mm View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M webrtc/sdk/objc/Framework/Classes/objcvideotracksource.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/test/fake_texture_frame.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/frame_generator_capturer.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/overuse_frame_detector.cc View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/receive_statistics_proxy_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video_frame.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
nisse-webrtc
PTAL. By now, almost all dependencies I've been able to find are updated, and I ...
3 years, 8 months ago (2017-04-04 14:02:52 UTC) #2
perkj_webrtc
lgtm
3 years, 8 months ago (2017-04-04 14:54:55 UTC) #3
mflodman
Sorry for the delay. On minor comment, then LGTM. https://codereview.webrtc.org/2622263002/diff/280001/webrtc/test/fake_texture_frame.h File webrtc/test/fake_texture_frame.h (right): https://codereview.webrtc.org/2622263002/diff/280001/webrtc/test/fake_texture_frame.h#newcode14 webrtc/test/fake_texture_frame.h:14: ...
3 years, 7 months ago (2017-04-27 14:43:00 UTC) #4
nisse-webrtc
https://codereview.webrtc.org/2622263002/diff/280001/webrtc/test/fake_texture_frame.h File webrtc/test/fake_texture_frame.h (right): https://codereview.webrtc.org/2622263002/diff/280001/webrtc/test/fake_texture_frame.h#newcode14 webrtc/test/fake_texture_frame.h:14: #include "webrtc/api/video/i420_buffer.h" On 2017/04/27 14:43:00, mflodman wrote: > Include ...
3 years, 7 months ago (2017-04-28 07:32:45 UTC) #5
nisse-webrtc
On 2017/04/28 07:32:45, nisse-webrtc wrote: > https://codereview.webrtc.org/2622263002/diff/280001/webrtc/test/fake_texture_frame.h > File webrtc/test/fake_texture_frame.h (right): > > https://codereview.webrtc.org/2622263002/diff/280001/webrtc/test/fake_texture_frame.h#newcode14 > ...
3 years, 7 months ago (2017-04-28 08:33:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2622263002/320001
3 years, 7 months ago (2017-04-28 12:40:46 UTC) #13
commit-bot: I haz the power
Committed patchset #17 (id:320001) as https://chromium.googlesource.com/external/webrtc/+/713a3bbcc74a4c1a1f54d6dbd0bdaa715f5c1ae1
3 years, 7 months ago (2017-04-28 12:43:25 UTC) #16
nisse-webrtc
3 years, 7 months ago (2017-04-28 13:03:30 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #17 id:320001) has been created in
https://codereview.webrtc.org/2845333002/ by nisse@webrtc.org.

The reason for reverting is: Broke Chrome build, see, e.g.,
http://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Builder/buil....

Powered by Google App Engine
This is Rietveld 408576698