Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2862573002: Reland of Added ARM Neon SIMD optimizations for AEC3 (Closed)

Created:
3 years, 7 months ago by peah-webrtc
Modified:
3 years, 7 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Added ARM Neon SIMD optimizations for AEC3 (patchset #1 id:1 of https://codereview.webrtc.org/2856113003/ ) Reason for revert: The original patch set was correct, but the Chromium bug number needed to be corrected. Original issue's description: > Revert of Added ARM Neon SIMD optimizations for AEC3 (patchset #2 id:970001 of https://codereview.webrtc.org/2834073005/ ) > > Reason for revert: > The bug number for the chromium bug was wrong. > > Original issue's description: > > Added ARM Neon optimizations for AEC3 > > > > This CL adds Neon SIMD optimizations for AEC3 on ARM, resulting > > in an 8 times complexity reduction. The optimizations are basically > > identical to what was already in place for SSE2. > > > > BUG=chromium:14993, webrtc:6018 > > > > Review-Url: https://codereview.webrtc.org/2834073005 > > Cr-Commit-Position: refs/heads/master@{#17993} > > Committed: https://chromium.googlesource.com/external/webrtc/+/f246b91eba0e8d95bd3fee4634887fb6d3017811 > > TBR=ivoc@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:14993, webrtc:6018 > > Review-Url: https://codereview.webrtc.org/2856113003 > Cr-Commit-Position: refs/heads/master@{#17994} > Committed: https://chromium.googlesource.com/external/webrtc/+/b70f8cfd4d5cf6fe31a8089df9955b7e7b7ebd32 TBR=ivoc@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:714993, webrtc:6018 Review-Url: https://codereview.webrtc.org/2862573002 Cr-Commit-Position: refs/heads/master@{#17997} Committed: https://chromium.googlesource.com/external/webrtc/+/5d153c76c60fc3388d60ff3b84a9b4b5557c57ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+621 lines, -6 lines) Patch
M webrtc/modules/audio_processing/aec3/adaptive_fir_filter.h View 4 chunks +20 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/adaptive_fir_filter.cc View 8 chunks +174 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc View 4 chunks +108 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/aec3_common.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec3/aec3_common.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/matched_filter.h View 1 chunk +13 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/matched_filter.cc View 3 chunks +118 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/matched_filter_unittest.cc View 1 chunk +39 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/vector_math.h View 4 chunks +84 lines, -0 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/vector_math_unittest.cc View 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
peah-webrtc
Created Reland of Added ARM Neon SIMD optimizations for AEC3
3 years, 7 months ago (2017-05-03 13:43:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2862573002/1
3 years, 7 months ago (2017-05-03 13:44:32 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 13:45:48 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5d153c76c60fc3388d60ff3b8...

Powered by Google App Engine
This is Rietveld 408576698