Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2856113003: Revert of Added ARM Neon SIMD optimizations for AEC3 (Closed)

Created:
3 years, 7 months ago by peah-webrtc
Modified:
3 years, 7 months ago
Reviewers:
ivoc
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, Andrew MacDonald, aleloi, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Added ARM Neon SIMD optimizations for AEC3 (patchset #2 id:970001 of https://codereview.webrtc.org/2834073005/ ) Reason for revert: The bug number for the chromium bug was wrong. Original issue's description: > Added ARM Neon optimizations for AEC3 > > This CL adds Neon SIMD optimizations for AEC3 on ARM, resulting > in an 8 times complexity reduction. The optimizations are basically > identical to what was already in place for SSE2. > > BUG=chromium:14993, webrtc:6018 > > Review-Url: https://codereview.webrtc.org/2834073005 > Cr-Commit-Position: refs/heads/master@{#17993} > Committed: https://chromium.googlesource.com/external/webrtc/+/f246b91eba0e8d95bd3fee4634887fb6d3017811 TBR=ivoc@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:14993, webrtc:6018 Review-Url: https://codereview.webrtc.org/2856113003 Cr-Commit-Position: refs/heads/master@{#17994} Committed: https://chromium.googlesource.com/external/webrtc/+/b70f8cfd4d5cf6fe31a8089df9955b7e7b7ebd32

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -622 lines) Patch
M webrtc/modules/audio_processing/aec3/adaptive_fir_filter.h View 4 chunks +0 lines, -20 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/adaptive_fir_filter.cc View 8 chunks +0 lines, -174 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/adaptive_fir_filter_unittest.cc View 4 chunks +3 lines, -108 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/aec3_common.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_processing/aec3/aec3_common.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/matched_filter.h View 1 chunk +0 lines, -13 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/matched_filter.cc View 3 chunks +0 lines, -118 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/matched_filter_unittest.cc View 1 chunk +3 lines, -40 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/vector_math.h View 4 chunks +0 lines, -84 lines 0 comments Download
M webrtc/modules/audio_processing/aec3/vector_math_unittest.cc View 1 chunk +0 lines, -59 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
peah-webrtc
Created Revert of Added ARM Neon SIMD optimizations for AEC3
3 years, 7 months ago (2017-05-03 13:40:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2856113003/1
3 years, 7 months ago (2017-05-03 13:40:42 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/b70f8cfd4d5cf6fe31a8089df9955b7e7b7ebd32
3 years, 7 months ago (2017-05-03 13:40:55 UTC) #6
peah-webrtc
3 years, 7 months ago (2017-05-03 13:43:02 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2862573002/ by peah@webrtc.org.

The reason for reverting is: The original patch set was correct, but the
Chromium bug number needed to be corrected..

Powered by Google App Engine
This is Rietveld 408576698